From: Andi Kleen <andi@firstfloor.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 01/15] ACPI: create kernel/acpi/
Date: Wed, 31 Dec 2008 15:21:08 +0100 [thread overview]
Message-ID: <87bpusv31n.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081231133901.GB2388@uranus.ravnborg.org> (Sam Ravnborg's message of "Wed, 31 Dec 2008 14:39:01 +0100")
Sam Ravnborg <sam@ravnborg.org> writes:
> Why is ACPI_CFLAGS exported?
>> +ACPI_CFLAGS := -Os
>> +
>> +ifdef CONFIG_ACPI_DEBUG
>> + ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT
>> +endif
>> +
>> +EXTRA_CFLAGS += $(ACPI_CFLAGS)
> A better way:
>
> ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT
Surely s/:=/+=/ ?
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-12-31 14:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 10:51 RFC - ACPI source code re-org Len Brown
2008-12-31 10:51 ` [PATCH 01/15] ACPI: create kernel/acpi/ Len Brown
2008-12-31 10:51 ` [PATCH 02/15] ACPI: delete include/acpi/platform/ Len Brown
2008-12-31 10:51 ` [PATCH 03/15] ACPICA: move common private headers under kernel/acpi/acpica/ Len Brown
2009-01-02 19:14 ` Ingo Molnar
2009-01-02 20:48 ` Len Brown
2009-01-07 22:10 ` Ingo Molnar
2009-01-08 16:03 ` Christoph Hellwig
2009-01-09 4:34 ` Len Brown
2009-01-11 4:09 ` Ingo Molnar
2009-01-02 21:56 ` Len Brown
2008-12-31 10:51 ` [PATCH 04/15] ACPICA: acdebug.h is private Len Brown
2008-12-31 10:51 ` [PATCH 05/15] ACPICA: delete acdisasm.h Len Brown
2008-12-31 10:51 ` [PATCH 06/15] ACPICA: acdispat.h is private Len Brown
2008-12-31 10:51 ` [PATCH 07/15] ACPICA: acevents.h " Len Brown
2008-12-31 10:51 ` [PATCH 08/15] ACPICA: acinterp.h " Len Brown
2008-12-31 10:51 ` [PATCH 09/15] ACPICA: acnamesp.h " Len Brown
2008-12-31 10:52 ` [PATCH 10/15] ACPICA: acopcode.h " Len Brown
2008-12-31 10:52 ` [PATCH 11/15] ACPICA: acparser.h " Len Brown
2008-12-31 10:52 ` [PATCH 12/15] ACPICA: acpredef.h " Len Brown
2008-12-31 10:52 ` [PATCH 13/15] ACPICA: acresrc.h, amlresrc.h are private Len Brown
2008-12-31 10:52 ` [PATCH 14/15] ACPICA: actables.h is private Len Brown
2008-12-31 10:52 ` [PATCH 15/15] ACPICA: amlcode.h " Len Brown
2008-12-31 13:39 ` [PATCH 01/15] ACPI: create kernel/acpi/ Sam Ravnborg
2008-12-31 14:21 ` Andi Kleen [this message]
2008-12-31 15:34 ` Sam Ravnborg
2009-01-02 21:44 ` [incremental-PATCH-for-Sam's-Review] ACPI: use ccflags-y instead of EXTRA_CFLAGS Len Brown
2009-01-02 21:52 ` Sam Ravnborg
2009-01-02 21:56 ` Andi Kleen
2009-01-02 22:01 ` Sam Ravnborg
2009-01-02 22:17 ` Len Brown
2009-01-02 22:46 ` Andi Kleen
2009-01-02 21:30 ` [PATCH 01/15] ACPI: create kernel/acpi/ Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpusv31n.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).