From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 01/15] ACPI: create kernel/acpi/ Date: Wed, 31 Dec 2008 15:21:08 +0100 Message-ID: <87bpusv31n.fsf@basil.nowhere.org> References: <1230720725-9376-1-git-send-email-lenb@kernel.org> <526647e1bb69fd3248558fce365bb1fbfb226ccd.1230719795.git.len.brown@intel.com> <20081231133901.GB2388@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from one.firstfloor.org ([213.235.205.2]:58882 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbYLaOTe (ORCPT ); Wed, 31 Dec 2008 09:19:34 -0500 In-Reply-To: <20081231133901.GB2388@uranus.ravnborg.org> (Sam Ravnborg's message of "Wed, 31 Dec 2008 14:39:01 +0100") Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Sam Ravnborg Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown Sam Ravnborg writes: > Why is ACPI_CFLAGS exported? >> +ACPI_CFLAGS := -Os >> + >> +ifdef CONFIG_ACPI_DEBUG >> + ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT >> +endif >> + >> +EXTRA_CFLAGS += $(ACPI_CFLAGS) > A better way: > > ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT Surely s/:=/+=/ ? -Andi -- ak@linux.intel.com