From: Punit Agrawal <punit.agrawal@arm.com>
To: Borislav Petkov <bp@suse.de>
Cc: linux-acpi@vger.kernel.org, lorenzo.pieralisi@arm.com,
sudeep.holla@arm.com, linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
James Morse <james.morse@arm.com>
Subject: Re: [PATCH 2/3] GHES: Move memory initialisation to ghes_probe()
Date: Tue, 15 Aug 2017 11:31:57 +0100 [thread overview]
Message-ID: <87fuctp1eq.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170815083543.rz7lr4sbjcn65xc4@pd.tnic> (Borislav Petkov's message of "Tue, 15 Aug 2017 10:35:43 +0200")
[ thanks for dropping the bad email! ]
Borislav Petkov <bp@suse.de> writes:
> On Tue, Aug 15, 2017 at 11:10:05AM +0100, Punit Agrawal wrote:
>> In the absence of any GHES entries these are wasted.
>
> I know. This whole APEI init code would need a proper cleanup, like
> acpi_pci_root_init() calls acpi_hest_init() and it shouldn't have to
> communicate through a variable with GHES whether to init or not but it
> should initialize GHES itself. And ghes_init() being a device_initcall()
> is just yuck.
I'd seen the link between acpi_pci_root_init() and acpi_hest_init() but
didn't want to open another can of worms... :)
$SUBJECT was my attempt (small) at improving the situation but I guess I
didn't go far enough.
>
> Something for the todo list I guess...
>
>> The system does not provide the Hardware Error Source Table (HEST) which
>> is checked in the hest driver (drivers/acpi/apei/hest.c).
>>
>> I think I'll go with your original suggestion to change hest_disable
>> from a boolean to something with more states. Re-checking for the HEST
>> table again feels like duplication.
>>
>> Makes sense?
>
> Right, and then depending on the setting of hest_disable, either issue
> the "HEST is not enabled" message or not.
Ack!
>
> Thanks.
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-08-15 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 13:36 [PATCH 0/3] Refactor GHES to better support non-APEI systems Punit Agrawal
2017-08-01 13:36 ` [PATCH 1/3] GHES: Expand the estatus pool in ghes_estatus_pool_init() Punit Agrawal
2017-08-01 13:36 ` [PATCH 2/3] GHES: Move memory initialisation to ghes_probe() Punit Agrawal
2017-08-01 14:04 ` Punit Agrawal
2017-08-14 19:22 ` Borislav Petkov
2017-08-15 10:10 ` Punit Agrawal
2017-08-15 8:35 ` Borislav Petkov
2017-08-15 10:31 ` Punit Agrawal [this message]
2017-08-15 10:56 ` Borislav Petkov
2017-08-01 13:36 ` [PATCH 3/3] ACPI / APEI: HEST: Don't set hest_disable if table not found Punit Agrawal
2017-08-09 9:24 ` [PATCH 0/3] Refactor GHES to better support non-APEI systems Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuctp1eq.fsf@e105922-lin.cambridge.arm.com \
--to=punit.agrawal@arm.com \
--cc=bp@suse.de \
--cc=james.morse@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox