[PATCH] ACPI: resource: Force irq1 edge low override on Infinity laptops

[PATCH] ACPI: resource: Force irq1 edge low override on Infinity laptops

[David McFarland]

A user reported a keyboard problem similar to ones reported with other
Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative
to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.

Link: https://lemmy.ml/post/9864736
Link: https://www.infinitygaming.com.au/bios/
Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com
---
 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 297a88587031..f692604b773c 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
 		},
 	},
+	{
+		.ident = "Infinity E15-5A165-BM",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		.ident = "Infinity E15-5A305-1M",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
-- 
2.40.1

Re: [PATCH] ACPI: resource: Force irq1 edge low override on Infinity laptops

[Rafael J. Wysocki]

Cc Hans and Mario.

On Sat, Dec 30, 2023 at 4:09 PM David McFarland <corngood@gmail.com> wrote:
>
> A user reported a keyboard problem similar to ones reported with other
> Zen laptops, on an Infinity E15-5A165-BM.
>
> Add board name matches for this model and one (untested) close relative
> to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.
>
> Link: https://lemmy.ml/post/9864736
> Link: https://www.infinitygaming.com.au/bios/
> Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com
> ---
>  drivers/acpi/resource.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 297a88587031..f692604b773c 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
>                 },
>         },
> +       {
> +               .ident = "Infinity E15-5A165-BM",

.ident is not needed any more.

Please add a comment identifying the machine(s) instead.

> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
> +               },
> +       },
> +       {
> +               .ident = "Infinity E15-5A305-1M",
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
> +               },
> +       },
>         { }
>  };
>
> --

Thanks!

[PATCH v2] ACPI: resource: Force irq1 edge low override on Infinity laptops

[David McFarland]

A user reported a keyboard problem similar to ones reported with other
Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative
to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.

Link: https://lemmy.ml/post/9864736
Link: https://www.infinitygaming.com.au/bios/
Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com
---
 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 297a88587031..6b64ea4e9c80 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
-- 
2.40.1

Re: [PATCH v2] ACPI: resource: Force irq1 edge low override on Infinity laptops

[Hans de Goede]

Hi David,

Thank you for your patch.

On 1/3/24 15:03, David McFarland wrote:
> A user reported a keyboard problem similar to ones reported with other
> Zen laptops, on an Infinity E15-5A165-BM.
> 
> Add board name matches for this model and one (untested) close relative
> to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.
> 
> Link: https://lemmy.ml/post/9864736
> Link: https://www.infinitygaming.com.au/bios/
> Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com

This patch seems to be based on an older version of the kernel.

Please base this on the latest code from:

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/?h=bleeding-edge

There is a single DMI match table there now for all AMD
laptops named irq1_edge_low_force_override[]

Which has a bunch of new entries, so your patch will not
apply cleanly as is.

Regards,

Hans




> ---
>  drivers/acpi/resource.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 297a88587031..6b64ea4e9c80 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
>  		},
>  	},
> +	{
> +		/* Infinity E15-5A165-BM */
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
> +		},
> +	},
> +	{
> +		/* Infinity E15-5A305-1M */
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
> +		},
> +	},
>  	{ }
>  };
>  

[PATCH v3] ACPI: resource: Add Infinity laptops to irq1_level_low_skip_override

[David McFarland]

A user reported a keyboard problem similar to ones reported with other
Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative
to irq1_level_low_skip_override.

Link: https://lemmy.ml/post/9864736
Link: https://www.infinitygaming.com.au/bios/
Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com
---

- v3: Rebased on bleeding-edge

Sorry, I should have realised based on other commits referencing the new
global array name.

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index c3536c236be9..575dad7aaaa7 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -489,6 +489,18 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "17U70P"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
-- 
2.40.1

[PATCH v4] ACPI: resource: Add Infinity laptops to irq1_level_low_force_override

[David McFarland]

A user reported a keyboard problem similar to ones reported with other
Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative
to irq1_level_low_force_override.

Link: https://lemmy.ml/post/9864736
Link: https://www.infinitygaming.com.au/bios/
Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com
---

- v4: fixed rebase error, adding to _force instead of _skip

Apologies, I messed up the rebase.  This one should put them in the
correct array.

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index c3536c236be9..0e2c397b1399 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -555,6 +555,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GM6BG0Q"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
-- 
2.40.1

[PATCH v5] ACPI: resource: Add Infinity laptops to irq1_edge_low_force_override

[David McFarland]

A user reported a keyboard problem similar to ones reported with other
Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative
to irq1_edge_low_force_override.

Link: https://lemmy.ml/post/9864736
Link: https://www.infinitygaming.com.au/bios/
Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com
---

- v5: fix commit message

Apologies again, in my haste I made a typo in the commit message.

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index c3536c236be9..0e2c397b1399 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -555,6 +555,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GM6BG0Q"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
-- 
2.40.1

Re: [PATCH v5] ACPI: resource: Add Infinity laptops to irq1_edge_low_force_override

[Rafael J. Wysocki]

On Wed, Jan 3, 2024 at 5:55 PM David McFarland <corngood@gmail.com> wrote:
>
> A user reported a keyboard problem similar to ones reported with other
> Zen laptops, on an Infinity E15-5A165-BM.
>
> Add board name matches for this model and one (untested) close relative
> to irq1_edge_low_force_override.
>
> Link: https://lemmy.ml/post/9864736
> Link: https://www.infinitygaming.com.au/bios/
> Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com
> ---
>
> - v5: fix commit message
>
> Apologies again, in my haste I made a typo in the commit message.
>
>  drivers/acpi/resource.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index c3536c236be9..0e2c397b1399 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -555,6 +555,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "GM6BG0Q"),
>                 },
>         },
> +       {
> +               /* Infinity E15-5A165-BM */
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
> +               },
> +       },
> +       {
> +               /* Infinity E15-5A305-1M */
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
> +               },
> +       },
>         { }
>  };
>
> --

Applied as 6.8 material, thanks!