* Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist
[not found] <4491BC6B.5000704@oracle.com>
@ 2006-06-20 3:33 ` Andrew Morton
2006-06-20 3:51 ` Ben Pfaff
2006-06-20 9:30 ` Matthew Garrett
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Morton @ 2006-06-20 3:33 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, len.brown, linux-acpi
On Thu, 15 Jun 2006 13:00:43 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> [UBUNTU:acpi] Add IBM R60E laptop to proc-idle blacklist.
>
> Reference: https://launchpad.net/distros/ubuntu/+source/linux-source-2.6.15/+bug/38228
> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commit;h=ce5e62bc55056049d192c422b6032f6a406e0ba2
>
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
> ---
> drivers/acpi/processor_idle.c | 3 +++
> 1 files changed, 3 insertions(+)
>
> --- linux-2617-rc6g7.orig/drivers/acpi/processor_idle.c
> +++ linux-2617-rc6g7/drivers/acpi/processor_idle.c
> @@ -142,6 +142,9 @@ static struct dmi_system_id __cpuinitdat
> { set_max_cstate, "IBM ThinkPad R40e", {
> DMI_MATCH(DMI_BIOS_VENDOR,"IBM"),
> DMI_MATCH(DMI_BIOS_VERSION,"1SET68WW") }, (void*)1},
> + { set_max_cstate, "IBM ThinkPad R40e", {
> + DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
> + DMI_MATCH(DMI_BIOS_VERSION, "1SET70WW") }, (void*)1},
> { set_max_cstate, "Medion 41700", {
> DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix Technologies LTD"),
> DMI_MATCH(DMI_BIOS_VERSION,"R01-A1J")}, (void *)1},
>
It seems that every R40e in the world is in that table.
Can/should we wildcard it? From my reading of dmi_check_system(), we can use
"" in place of the "1SET..." string and it'll dtrt?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist
2006-06-20 3:33 ` [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist Andrew Morton
@ 2006-06-20 3:51 ` Ben Pfaff
2006-06-20 5:16 ` Randy.Dunlap
2006-06-20 9:30 ` Matthew Garrett
2006-06-20 9:30 ` Matthew Garrett
1 sibling, 2 replies; 6+ messages in thread
From: Ben Pfaff @ 2006-06-20 3:51 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi
Andrew Morton <akpm@osdl.org> writes:
> On Thu, 15 Jun 2006 13:00:43 -0700
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> [UBUNTU:acpi] Add IBM R60E laptop to proc-idle blacklist.
>> + { set_max_cstate, "IBM ThinkPad R40e", {
>> + DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
>> + DMI_MATCH(DMI_BIOS_VERSION, "1SET70WW") }, (void*)1},
>
> It seems that every R40e in the world is in that table.
The email says R60e.
The string says R40e.
Which is correct?
--
Ben Pfaff
email: blp@cs.stanford.edu
web: http://benpfaff.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist
2006-06-20 3:51 ` Ben Pfaff
@ 2006-06-20 5:16 ` Randy.Dunlap
2006-06-20 9:30 ` Matthew Garrett
1 sibling, 0 replies; 6+ messages in thread
From: Randy.Dunlap @ 2006-06-20 5:16 UTC (permalink / raw)
To: blp, bcollins; +Cc: linux-acpi, linux-kernel
On Mon, 19 Jun 2006 20:51:09 -0700 Ben Pfaff wrote:
> Andrew Morton <akpm@osdl.org> writes:
>
> > On Thu, 15 Jun 2006 13:00:43 -0700
> > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >
> >> [UBUNTU:acpi] Add IBM R60E laptop to proc-idle blacklist.
>
> >> + { set_max_cstate, "IBM ThinkPad R40e", {
> >> + DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
> >> + DMI_MATCH(DMI_BIOS_VERSION, "1SET70WW") }, (void*)1},
> >
> > It seems that every R40e in the world is in that table.
>
> The email says R60e.
> The string says R40e.
> Which is correct?
Good question for Ben. Ben??
Current ubuntu-dapper git is still like this.
---
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist
2006-06-20 3:33 ` [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist Andrew Morton
2006-06-20 3:51 ` Ben Pfaff
@ 2006-06-20 9:30 ` Matthew Garrett
2006-06-20 19:56 ` Randy Dunlap
1 sibling, 1 reply; 6+ messages in thread
From: Matthew Garrett @ 2006-06-20 9:30 UTC (permalink / raw)
To: Andrew Morton; +Cc: Randy Dunlap, linux-kernel, len.brown, linux-acpi
On Mon, Jun 19, 2006 at 08:33:33PM -0700, Andrew Morton wrote:
> > + { set_max_cstate, "IBM ThinkPad R40e", {
> > + DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
> > + DMI_MATCH(DMI_BIOS_VERSION, "1SET70WW") }, (void*)1},
> It seems that every R40e in the world is in that table.
>
> Can/should we wildcard it? From my reading of dmi_check_system(), we can use
> "" in place of the "1SET..." string and it'll dtrt?
Wouldn't that result in every machine with "IBM" as the BIOS vendor
having their maximum c-state limited?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist
2006-06-20 3:51 ` Ben Pfaff
2006-06-20 5:16 ` Randy.Dunlap
@ 2006-06-20 9:30 ` Matthew Garrett
1 sibling, 0 replies; 6+ messages in thread
From: Matthew Garrett @ 2006-06-20 9:30 UTC (permalink / raw)
To: Ben Pfaff; +Cc: linux-acpi, linux-kernel
On Mon, Jun 19, 2006 at 08:51:09PM -0700, Ben Pfaff wrote:
> The email says R60e.
> The string says R40e.
> Which is correct?
The string is correct. There is no R60e, to the best of my knowledge.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist
2006-06-20 9:30 ` Matthew Garrett
@ 2006-06-20 19:56 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2006-06-20 19:56 UTC (permalink / raw)
To: Matthew Garrett; +Cc: Andrew Morton, linux-kernel, len.brown, linux-acpi
Matthew Garrett wrote:
> On Mon, Jun 19, 2006 at 08:33:33PM -0700, Andrew Morton wrote:
>>> + { set_max_cstate, "IBM ThinkPad R40e", {
>>> + DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
>>> + DMI_MATCH(DMI_BIOS_VERSION, "1SET70WW") }, (void*)1},
>
>> It seems that every R40e in the world is in that table.
>>
>> Can/should we wildcard it? From my reading of dmi_check_system(), we can use
>> "" in place of the "1SET..." string and it'll dtrt?
>
> Wouldn't that result in every machine with "IBM" as the BIOS vendor
> having their maximum c-state limited?
Yes. DMI_MATCH() specifies substring matching, so _if we knew_
that any BIOS version that began with "1SET4", "1SET5", "1SET6",
or "1SET7" needed C-state limiting, the table could be made a lot
smaller. But then it may need some exceptions, so just sticking
with full version strings seems reasonable to me.
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-06-20 19:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4491BC6B.5000704@oracle.com>
2006-06-20 3:33 ` [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist Andrew Morton
2006-06-20 3:51 ` Ben Pfaff
2006-06-20 5:16 ` Randy.Dunlap
2006-06-20 9:30 ` Matthew Garrett
2006-06-20 9:30 ` Matthew Garrett
2006-06-20 19:56 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox