2.5.64 kernel bug

2.5.64 kernel bug

[Shawn P. Garbett]

I just got a P2120 laptop and really really want ACPI working. I grabbed the 
2.5.64 kernel and it didn't compile. Looking back through the archives of 
this list I found nothing related to this. 

I'm a proficient programmer, but have never done any serious kernel work under 
linux. 

Here's what I changed to make it compile: 

sputnik:/usr/src/linux# diff drivers/cpufreq/userspace.c.orig 
drivers/cpufreq/userspace.c
514c514
<               device_create_file (policy->intf.dev, 
&dev_attr_scaling_setspeed );
---
>               device_create_file (policy->dev, &dev_attr_scaling_setspeed);
523c523
<               device_remove_file (policy->intf.dev, 
&dev_attr_scaling_setspeed
);
---
>               device_remove_file (policy->dev, &dev_attr_scaling_setspeed);



Shawn


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com

Re: 2.5.64 kernel bug

[Patrick Mochel]

On Fri, 7 Mar 2003, Shawn P. Garbett wrote:

> I just got a P2120 laptop and really really want ACPI working. I grabbed the 
> 2.5.64 kernel and it didn't compile. Looking back through the archives of 
> this list I found nothing related to this. 

There have been at least two patches posted to fix this on linux-kernel,
and a third that went to Linux directly.  I recommend either getting the
latest snapshot from kernel.org, or just using the fix you posted below. 

BTW, the cpufreq code is not acpi-specific, and this report should have
gone to either the cpufreq list, or linux-kernel.

> I'm a proficient programmer, but have never done any serious kernel work under 
> linux. 
> 
> Here's what I changed to make it compile: 
> 
> sputnik:/usr/src/linux# diff drivers/cpufreq/userspace.c.orig 
> drivers/cpufreq/userspace.c
> 514c514
> <               device_create_file (policy->intf.dev, 
> &dev_attr_scaling_setspeed );
> ---
> >               device_create_file (policy->dev, &dev_attr_scaling_setspeed);
> 523c523
> <               device_remove_file (policy->intf.dev, 
> &dev_attr_scaling_setspeed
> );
> ---
> >               device_remove_file (policy->dev, &dev_attr_scaling_setspeed);

One more thing - when you post patches, please generate them with '-u'. 


	-pat



-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com

Re: 2.5.64 kernel bug

[Alexander Hoogerhuis]

Patrick Mochel <mochel-3NddpPZAyC0@public.gmane.org> writes:
>
> There have been at least two patches posted to fix this on linux-kernel,
> and a third that went to Linux directly.  I recommend either getting the
> latest snapshot from kernel.org, or just using the fix you posted below. 
> 

The -mm patches seems to be shaping up nicely and might be a good
alternative instead of Linus' tree. Not that he's doing anything bad,
just that his tree is seem to be more in a state of flux, and Andrew
Morton seems to be accepting a lot of fixes to make it testable :)

I'm punting happily on 2.5.64-mm1 now, and if I could only find a
patch that lets me load my own DSDT. I'm sure its out there, I haven't
had a look in the archives yet (they're hard to get at from 39,000ft
above Sumatera) ;)

mvh,
A
-- 
Alexander Hoogerhuis                               | alexh-rpjHciJLgqZBDgjK7y7TUQ@public.gmane.org
CCNP - CCDP - MCNE - CCSE                          | +47 908 21 485
"You have zero privacy anyway. Get over it."  --Scott McNealy


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com