Re: [PATCH]Panasonic Hotkey Driver v0.5 [2/2]

[Hiroshi Miura <miura-yiisDzvROlQdnm+yROfE0A@public.gmane.org>]

Hi,

I got internal datasheet from panasonic lets note team.
They said that they use value 0-20 for lcd brightness and
we should use these values for safety.

The datasheet is written by only Japanese.

sinf description.

SINF： get all setting information
  BIOS struct
    package() {
      mumber of maxmum batteries,	/* now assume only 0,1, or 2 */
      type of LCD ,	/* 0.. normal,  1..semi-transparent */
      maximum brightness on AC,
      minimum brightness on AC,
      current brightness on AC,	
      maximum brightness on DC,	/* if no battery, fix to 0 */
      minimum brightness on DC,	/* if no battery, fix to 0 */
      current brightness on DC,	/* if no battery, fix to 0 */
      current mute state,
      reserved ( == 1),
      current environment state, /* normal temp=0x01,high temp=0x81,no support=0x00 */
    }

At Fri, 20 Aug 2004 10:43:28 -0700,
Nate Lawson wrote:
> 
> David Bronaugh wrote:
> > Hiroshi Miura wrote:
> >> It's from Panasonic spec.
> >>
> >> 0,n  -- brightness on AC 1,n  -- brightness on battery.
> >> If pc go suspend/resume, BIOS set brightness according to this value.
> >>
> >> I should further study this interface.
> >>
> > At least on my R1, this function is incorrect. Brightness values range 
> > from 0-255 on my R1. Setting field 4 and field 7 of sinf have exactly 

Ok, I'll ask to panasonic team that reason.

> > the same effect (it would appear that they map to the same function) 

no. after hibernate/resume, it make effect by BIOS, i think.

> > even though they end up storing different values; disconnecting and 
> > connecting AC power does not change how bright the screen is at all. I

When running OS, brightness change is a work for OS. not BIOS on this spec.
If BIOS can handle brightness by SMI, OS may not be able to handle it.
 
> > believe this is intentional; however, I also believe that using ACPI to 
> > store values like this is pointless and it would be better to simplify 
> > the interface.

I want to simplify interface too, but I also want to implement proper functions.

> > My experience is that changing the code to accept values from 0-255 
> > allows me to set the full range of screen brightnesses; however, setting 

Yes, lets note member said me bios can accept 0-255 but they don't know what 
happen over 20, because they only test 0-20 on Windows XP.

The specsheet I have is up-to-date one, then it might change before.
At least, between R1/T1 and R2/T2/W2/Y2/R3 we have difference.

> > values less than 11 makes the screen flicker like crazy (I assume this 
> > is because I am underpowering the backlight). So perhaps a floor of, 
> > say, 15 on the screen brightness would be a good choice to avoid problems.
> > Also a small complaint -- displaying all 6 registers in 
> > acpi_pcc_read_brightness is confusing (not to me since I understand the 
> > code, but to end users).

My code assumes platform is R2/Y2/T2/W2/R3. R1 is not my focus now.
+/* device(HKEY) definitions */
+#define HKEY_HID               "MAT0019"

my driver handle HID 'MAT0019' but my R1 has HID 'MAT0012'.
It means R1 has different functionality.

My R1 has no SINF methods. it can controll brightness by SMM/SMI functionality.

What your R1's HID or DSDT?
I cannot find other version of DSDT on acpi.sourceforge.net.

> We handle these different laptops correctly in the FreeBSD 
> acpi_panasonic driver.  It may be a good example for you.
> 
> -- 
> Nate

thanks. I want to refer.

-- 
Hiroshi Miura  --- http://www.da-cha.org/  --- miura-yiisDzvROlQdnm+yROfE0A@public.gmane.org
NTTDATA Corp. OpenSource Software Center. --- miurahr-3MafRgGXt7BL9jVzuh4AOg@public.gmane.org 
NTTDATA Intellilink Corp. OpenSource Engineering Dev. -- miurahr-w0OK63jvRlAuJ+9fw/WgBHgSJqDPrsil@public.gmane.org
Key fingerprint = 9117 9407 5684 FBF1 4063  15B4 401D D077 04AB 8617


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285