From: Andi Kleen <andi@firstfloor.org>
To: John Keller <jpk@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
takayoshi.kochi@gmail.com
Subject: Re: [PATCH] x86: Allow MMCONFIG above 4GB on x86_64
Date: Sun, 13 Jul 2008 17:36:18 +0200 [thread overview]
Message-ID: <87r69xzthp.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080709204127.1458.5727.77728@attica.americas.sgi.com> (John Keller's message of "Wed, 9 Jul 2008 15:41:27 -0500 (CDT)")
John Keller <jpk@sgi.com> writes:
>
> A similar patch was submitted over a year ago, but apparently was not
> merged in.
There's no reason at all to make this 64bit only. A PAE 32bit kernel
can also access data above 4GB. So an ifdef is the wrong way.
The reason the check is there is that there are lots of
x86 BIOS that report wrong mmconfig and this way there's another
sanity check.
You'll need either to find a way to preserve this check
on kernels not running on your system or show that the
sanity check is not needed anymore. The later would
be likely tricky.
-Andi
next prev parent reply other threads:[~2008-07-13 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 20:41 [PATCH] x86: Allow MMCONFIG above 4GB on x86_64 John Keller
2008-07-09 21:02 ` Yinghai Lu
2008-07-10 7:28 ` Kenji Kaneshige
2008-07-13 15:36 ` Andi Kleen [this message]
2008-07-18 12:38 ` Ingo Molnar
2008-07-18 13:02 ` John Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r69xzthp.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=jpk@sgi.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=takayoshi.kochi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).