* GHES platform devices
@ 2016-11-16 21:36 Bjorn Helgaas
2016-11-17 1:27 ` Huang, Ying
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2016-11-16 21:36 UTC (permalink / raw)
To: Huang Ying; +Cc: Rafael J. Wysocki, Len Brown, linux-acpi, linux-kernel
Hi Huang,
7ad6e9435596 ("ACPI, APEI, Manage GHES as platform devices") added
platform devices so the GHES driver could be built as a module and
automatically loaded when needed.
Later, 86cd47334b00 ("ACPI, APEI, GHES, Prevent GHES to be built as
module") removed the ability to build GHES as a module.
Should we revert 7ad6e9435596? It's inconsistent to handle GHES, but
not other error sources, as a platform device. And having it as a
platform device probably puts gunk in sysfs that we don't need.
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: GHES platform devices
2016-11-16 21:36 GHES platform devices Bjorn Helgaas
@ 2016-11-17 1:27 ` Huang, Ying
0 siblings, 0 replies; 2+ messages in thread
From: Huang, Ying @ 2016-11-17 1:27 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Huang Ying, Rafael J. Wysocki, Len Brown, linux-acpi,
linux-kernel
Hi, Bjorn,
Bjorn Helgaas <helgaas@kernel.org> writes:
> Hi Huang,
>
> 7ad6e9435596 ("ACPI, APEI, Manage GHES as platform devices") added
> platform devices so the GHES driver could be built as a module and
> automatically loaded when needed.
>
> Later, 86cd47334b00 ("ACPI, APEI, GHES, Prevent GHES to be built as
> module") removed the ability to build GHES as a module.
>
> Should we revert 7ad6e9435596? It's inconsistent to handle GHES, but
> not other error sources, as a platform device. And having it as a
> platform device probably puts gunk in sysfs that we don't need.
Although other error sources are not platform devices, I think it is
generally good to make GHES platform devices. To take advantage of
automatic module loading, we can make ghes a module again, but prevent
it from unloading. What do you think about that?
Best Regards,
Huang, Ying
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-17 1:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 21:36 GHES platform devices Bjorn Helgaas
2016-11-17 1:27 ` Huang, Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).