From: Punit Agrawal <punit.agrawal@bytedance.com>
To: Riwen Lu <luriwen@hotmail.com>
Cc: rafael@kernel.org, lenb@kernel.org, rui.zhang@intel.com,
robert.moore@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, devel@acpica.org,
punit.agrawal@bytedance.com, Riwen Lu <luriwen@kylinos.cn>
Subject: Re: [PATCH v2] ACPI/processor: Remove unused function acpi_processor_get_limit_info()
Date: Fri, 17 Jun 2022 10:42:14 +0100 [thread overview]
Message-ID: <87v8szoccp.fsf@stealth> (raw)
In-Reply-To: <TYWP286MB2601A75D517AE71EE569CE15B1AF9@TYWP286MB2601.JPNP286.PROD.OUTLOOK.COM> (Riwen Lu's message of "Fri, 17 Jun 2022 10:51:52 +0800")
Riwen Lu <luriwen@hotmail.com> writes:
> From: Riwen Lu <luriwen@kylinos.cn>
>
> Commit 22e7551eb6fd ("ACPI / processor: Remove acpi_processor_get_limit_info()"),
> left behind this, remove it.
>
> Signed-off-by: Riwen Lu <luriwen@kylinos.cn>
>
> ---
> v1 -> v2:
> - Make this patch base on ("ACPI: Split out processor thermal register
> from ACPI PSS").
For such changes, it is better to send all the related patches as a
series so it's easy to see the dependencies . In a series the easy /
obvious fixes should be earlier so it's easier for them to be merged
while the more significant changes are still being discussed.
Hopefully in this case Rafael too agrees with the dependency patch -
otherwise, it's just extra churn on the lists.
But don't resend just yet - give some time for others to add their
feedback.
> ---
> include/acpi/processor.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index ba1e3ed98d3d..9fa49686957a 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -441,7 +441,6 @@ static inline int acpi_processor_hotplug(struct acpi_processor *pr)
> #endif /* CONFIG_ACPI_PROCESSOR_IDLE */
>
> /* in processor_thermal.c */
> -int acpi_processor_get_limit_info(struct acpi_processor *pr);
> int acpi_processor_thermal_init(struct acpi_processor *pr,
> struct acpi_device *device);
> void acpi_processor_thermal_exit(struct acpi_processor *pr,
Fwiw,
Reviewed-by: Punit Agrawal <punit.agrawal@bytedance.com>
next prev parent reply other threads:[~2022-06-17 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220617025152.1908638-1-luriwen@hotmail.com>
2022-06-17 2:51 ` [PATCH v2] ACPI/processor: Remove unused function acpi_processor_get_limit_info() Riwen Lu
2022-06-17 9:42 ` Punit Agrawal [this message]
2022-06-29 16:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8szoccp.fsf@stealth \
--to=punit.agrawal@bytedance.com \
--cc=devel@acpica.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luriwen@hotmail.com \
--cc=luriwen@kylinos.cn \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox