Re: [PATCH]Panasonic Hotkey Driver

[Hiroshi Miura <miura-yiisDzvROlQdnm+yROfE0A@public.gmane.org>]

Hi,

At Wed, 18 Aug 2004 23:00:57 -0700,
David Bronaugh wrote:
> +
> +#define	LCD_MAX_BRIGHTNESS 255

max brightness is defined on BIOS sinf field 2,3 and 5,6.
I should use these value for input check. 

> +
> +/* This may be magical -- beware */
> +#define LCD_BRIGHTNESS_INCREMENT 17

more description about it?
flickering?

> +
> +/* Registers of SINF */
> +#define	SINF_LCD_BRIGHTNESS		4

brightness setting are  defined on filed 4 and 7.
meaning is posted by another mail.

<SNIP>


> +static unsigned long write_brightness(const char *p, unsigned long count)
> +{
> +	int brightness = simple_strtol(p, NULL, 10) * LCD_BRIGHTNESS_INCREMENT;
> +	union acpi_object data[2];
> +	struct acpi_object_list args;
> +	uint32_t status;
> +
> +	/* Clean up incoming data */
> +	if (brightness > LCD_MAX_BRIGHTNESS) {
> +		brightness = LCD_MAX_BRIGHTNESS;
> +	} else if (brightness < 0) {
> +		brightness = 0;
> +	}
> +
> +	data[0].type = ACPI_TYPE_INTEGER;
> +	data[0].integer.value = SINF_LCD_BRIGHTNESS;
> +	data[1].type = ACPI_TYPE_INTEGER;
> +	data[1].integer.value = brightness;
> +	args.pointer = data;
> +	args.count = 2;
> +
> +	status = acpi_evaluate_object(NULL,
> +				      DEVICE_NAME_HKEY "." METHOD_HKEY_SSET,
> +				      &args, NULL);
> +
> +	if (ACPI_FAILURE(status)) {
> +		printk(KERN_INFO "Could not write display brightness");
> +	}
> +
> +	return count;
> +}

I want to incorporate this code except for max_value checking.

-- 
Hiroshi Miura  --- http://www.da-cha.org/  --- miura-yiisDzvROlQdnm+yROfE0A@public.gmane.org
NTTDATA Corp. OpenSource Software Center. --- miurahr-3MafRgGXt7BL9jVzuh4AOg@public.gmane.org 
NTTDATA Intellilink Corp. OpenSource Engineering Dev. -- miurahr-w0OK63jvRlAuJ+9fw/WgBHgSJqDPrsil@public.gmane.org
Key fingerprint = 9117 9407 5684 FBF1 4063  15B4 401D D077 04AB 8617


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285