Re: [PATCH v2 29/29] arm_mpam: Add kunit tests for props_mismatch()

Ben Horgan
2025-09-12T16:02:02Z

Hi James,

On 9/10/25 21:43, James Morse wrote:
> When features are mismatched between MSC the way features are combined
> to the class determines whether resctrl can support this SoC.
>
> Add some tests to illustrate the sort of thing that is expected to
> work, and those that must be removed.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> Changes since v1:
> * Waggled some words in comments.
> * Moved a bunch of variables to be global - shuts up a compiler warning.
> ---
> drivers/resctrl/mpam_internal.h | 8 +-
> drivers/resctrl/test_mpam_devices.c | 321 ++++++++++++++++++++++++++++
> 2 files changed, 328 insertions(+), 1 deletion(-)
>

Looks good to me, I checked the tests for v1. I agree with Jonathan that
you could make RESET_FAKE_HIEARCHY() a function now that you've changed
to use globals.

Reviewed-by: Ben Horgan <ben.horgan@arm.com>

Thanks,

Ben