From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v1 5/5] ACPI: thermal: Eliminate struct acpi_thermal_state_flags
Date: Wed, 31 May 2023 10:20:09 +0200 [thread overview]
Message-ID: <8a8dc05b-f173-bea8-a59a-137b95007be6@intel.com> (raw)
In-Reply-To: <3737693.kQq0lBPeGt@kreacher>
On 5/30/2023 5:45 PM, Rafael J. Wysocki wrote:
> |From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Notice that the enabled flag is only needed for active trip points, so drop struct acpi_thermal_state_flags, add a simple "bool valid" field to the definitions of all trip point structures instead of flags and add a "bool enabled" field to struct acpi_thermal_active. Adjust the code using the modified structures accordingly. No intentional functional impact. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> --- drivers/acpi/thermal.c | 132 +++++++++++++++++++++++-------------------------- 1 file changed, 64 insertions(+), 68 deletions(-)|
Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com>
> ||
prev parent reply other threads:[~2023-05-31 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 15:39 [PATCH v1 0/5] ACPI: thermal: Assorted cleanups Rafael J. Wysocki
2023-05-30 15:44 ` [PATCH v1 1/5] ACPI: thermal: Use BIT() macro for defining flags Rafael J. Wysocki
2023-05-31 7:33 ` Wilczynski, Michal
2023-05-30 15:44 ` [PATCH v1 2/5] ACPI: thermal: Drop redundant ACPI_TRIPS_REFRESH_DEVICES symbol Rafael J. Wysocki
2023-05-31 7:48 ` Wilczynski, Michal
2023-05-31 14:48 ` Rafael J. Wysocki
2023-05-30 15:44 ` [PATCH v1 3/5] ACPI: thermal: Move symbol definitions to one place Rafael J. Wysocki
2023-05-31 7:58 ` Wilczynski, Michal
2023-05-30 15:44 ` [PATCH v1 4/5] ACPI: thermal: Move acpi_thermal_driver definition Rafael J. Wysocki
2023-05-31 8:03 ` Wilczynski, Michal
2023-05-30 15:45 ` [PATCH v1 5/5] ACPI: thermal: Eliminate struct acpi_thermal_state_flags Rafael J. Wysocki
2023-05-31 8:20 ` Wilczynski, Michal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a8dc05b-f173-bea8-a59a-137b95007be6@intel.com \
--to=michal.wilczynski@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox