public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Ale <patrick.ale-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Oisín Mac Fhearaí" <destynova-iUB+o6dfpG8i1yMB4YHZDQ@public.gmane.org>
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	"Yu, Luming" <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: Acer Aspire 1705SMi LNKx?
Date: Tue, 26 Oct 2004 13:54:46 +0200	[thread overview]
Message-ID: <8d158e1f0410260454498849ac@mail.gmail.com> (raw)
In-Reply-To: <200410252247.39042.destynova-iUB+o6dfpG8i1yMB4YHZDQ@public.gmane.org>

Heya,

@@ -3829,13 +3831,14 @@

        If (LEqual (Arg0, 0x05))
        {
            \_SB.PCI0.LPCB.PHSR (0x06, 0x00)
        }
+       Return(Package(2){0, 0})

Does this actually work? When I try to compile it gives me an error
about an unexpected "("


Take care!

Patrick


On Mon, 25 Oct 2004 22:47:38 +0100, Oisín Mac Fhearaí
<destynova-iUB+o6dfpG8i1yMB4YHZDQ@public.gmane.org> wrote:
> On Monday 25 October 2004 16:52, Yu, Luming wrote:
> > It's nice to hear that you have fixed the buggy DSDT.
> > But I want to say MS windows should be ok with
> > the original DSDT, which breaks linux somehow.
> > To make sure linux can live with the original one,
> > I think we need to identify the quirks in the specific box, that
> > we can take into linux acpi for the sake of compatibility.
> > So, please give a brief description on what you did.
> >
> > Thanks
> > Luming
> 
> The thing that worries me a little about this is, as time goes by and you
> create workarounds in the ACPI code (as, presumably, Windows has) for machine
> specific behaviour, will we end up with a constantly growing mess of code to
> handle them all, or will workarounds be phased out in favour of proper fixes?
> 
> I've uploaded the original binary dsdt, disassembled version (which I did
> using quite an old version of iasl) and fixed version to
> http://www.redbrick.dcu.ie/~exolon/dsdt , /dsdt.dsl and /fixed.dsl
> respectively.
> 
> Here is the -U5 diff for summary. The fixes I used were all standard except
> for the Z00D problem. I found no references to Z00D in any of the tables
> supplied by the machine, so using a fixed version uploaded to the dsdt
> repository, replaced them with Z00C. Robert Moore mentioned that these values
> may get overwritten anyway and 0 would also have worked, so I suppose it
> doesn't matter. :)
> 
> good luck,
> Oisín
> 
> ___
> 
> --- dsdt.dsl    2004-10-25 22:11:22.501511136 +0100
> +++ fixed.dsl   2004-10-25 22:11:03.349422696 +0100
> @@ -1,10 +1,10 @@
>  /*
>   * Intel ACPI Component Architecture
> - * AML Disassembler version 20040715
> + * AML Disassembler version 20030918
>   *
> - * Disassembly of dsdt, Mon Oct 25 22:11:22 2004
> + * Disassembly of dsdt, Mon Aug 30 08:05:46 2004
>   */
>  DefinitionBlock ("DSDT.aml", "DSDT", 1, "PTLTD ", "650M", 100925440)
>  {
>      OperationRegion (P80G, SystemIO, 0x80, 0x01)
>      Field (P80G, ByteAcc, NoLock, Preserve)
> @@ -19,11 +19,11 @@
>          FANR,   8,
>          Offset (0x58),
>          F1CR,   8
>      }
> 
> -    Scope (_PR)
> +    Scope (\_PR)
>      {
>          Processor (CPU0, 0x00, 0x00008010, 0x06) {}
>      }
> 
>      Name (_S0, Package (0x02)
> @@ -50,11 +50,11 @@
>      Method (_PIC, 1, NotSerialized)
>      {
>          Store (Arg0, PICF)
>      }
> 
> -    Scope (_SB)
> +    Scope (\_SB)
>      {
>          Name (OSTB, Ones)
>          Name (FWSO, "FWSO")
>          Name (ECEN, 0x00)
>          Name (ACST, 0x01)
> @@ -838,10 +838,11 @@
>                              {
>                                  Notify (VGA, 0x80)
>                                  Return (0x00)
>                              }
>                          }
> +                       Return (0x00)
>                      }
> 
>                      Method (USTA, 0, NotSerialized)
>                      {
>                          If (LEqual (\_SB.PCI0.LPCB.Z000, 0x00))
> @@ -3425,12 +3426,12 @@
>                  "          "
>              })
>              Name (PBST, Package (0x04)
>              {
>                  0x00,
> -                Z00D,
> -                Z00D,
> +                Z00C,
> +                Z00C,
>                  0x2710
>              })
>              Name (ERRC, 0x00)
>              Name (_PCL, Package (0x01)
>              {
> @@ -3719,10 +3720,11 @@
>                          }
>                      }
>                  }
> 
>                  Decrement (Local1)
> +               Return (0x0)
>              }
>          }
> 
>          Scope (\_TZ)
>          {
> @@ -3829,13 +3831,14 @@
> 
>          If (LEqual (Arg0, 0x05))
>          {
>              \_SB.PCI0.LPCB.PHSR (0x06, 0x00)
>          }
> +       Return(Package(2){0, 0})
>      }
> 
> -    Scope (_GPE)
> +    Scope (\_GPE)
>      {
>          Method (_L17, 0, NotSerialized)
>          {
>              Notify (\_SB.LID, 0x80)
>          }
> 
> 
>


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

  parent reply	other threads:[~2004-10-26 11:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-25 15:52 Acer Aspire 1705SMi LNKx? Yu, Luming
2004-10-25 19:10 ` Patrick Ale
     [not found]   ` <8d158e1f04102512101b5808e2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2004-10-25 19:18     ` Patrick Ale
2004-10-25 21:47 ` Oisín Mac Fhearaí
     [not found]   ` <200410252247.39042.destynova-iUB+o6dfpG8i1yMB4YHZDQ@public.gmane.org>
2004-10-26 11:54     ` Patrick Ale [this message]
     [not found]       ` <8d158e1f0410260454498849ac-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2004-10-26 18:46         ` Patrick Ale
     [not found]           ` <8d158e1f0410261146721481ed-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2004-10-27  5:31             ` Oisín Mac Fhearaí
  -- strict thread matches above, loose matches on Subject: below --
2004-10-27 21:54 Moore, Robert
2004-10-27  5:36 Yu, Luming
2004-10-27  1:35 Yu, Luming
2004-10-25  8:09 Oisín Mac Fhearaí
     [not found] ` <200410250909.41761.destynova-iUB+o6dfpG8i1yMB4YHZDQ@public.gmane.org>
2004-10-25 14:30   ` Patrick Ale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d158e1f0410260454498849ac@mail.gmail.com \
    --to=patrick.ale-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=destynova-iUB+o6dfpG8i1yMB4YHZDQ@public.gmane.org \
    --cc=luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox