From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Ale Subject: Re: Acer Aspire 1705SMi LNKx? Date: Tue, 26 Oct 2004 20:46:06 +0200 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <8d158e1f0410261146721481ed@mail.gmail.com> References: <3ACA40606221794F80A5670F0AF15F84041ABFE3@pdsmsx403> <200410252247.39042.destynova@esatclear.ie> <8d158e1f0410260454498849ac@mail.gmail.com> Reply-To: Patrick Ale Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <8d158e1f0410260454498849ac-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: =?ISO-8859-1?Q?Ois=EDn_Mac_Fheara=ED?= Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Yu, Luming" List-Id: linux-acpi@vger.kernel.org Hello, When I use the fixed.dsl you mentioned in your earlyer mail I dont get the compile errors. Unfortunately the error messages regarding the PCI0.LNK thingies still appear for me. But like I mentioned, I have an Aspire 1703 so maybe for me the changes you made dont work quite as expected on an Aspire 1705 altho the earlyer changes that were needed were the same as for me. I apriciate your efford and time nevertheless. I'll just have to look a bit further. Thanks! Patrick On Tue, 26 Oct 2004 13:54:46 +0200, Patrick Ale wro= te: > Heya, >=20 > @@ -3829,13 +3831,14 @@ >=20 > If (LEqual (Arg0, 0x05)) > { > \_SB.PCI0.LPCB.PHSR (0x06, 0x00) > } > + Return(Package(2){0, 0}) >=20 > Does this actually work? When I try to compile it gives me an error > about an unexpected "(" >=20 > Take care! >=20 > Patrick >=20 > On Mon, 25 Oct 2004 22:47:38 +0100, Ois=EDn Mac Fheara=ED >=20 >=20 > wrote: > > On Monday 25 October 2004 16:52, Yu, Luming wrote: > > > It's nice to hear that you have fixed the buggy DSDT. > > > But I want to say MS windows should be ok with > > > the original DSDT, which breaks linux somehow. > > > To make sure linux can live with the original one, > > > I think we need to identify the quirks in the specific box, that > > > we can take into linux acpi for the sake of compatibility. > > > So, please give a brief description on what you did. > > > > > > Thanks > > > Luming > > > > The thing that worries me a little about this is, as time goes by and y= ou > > create workarounds in the ACPI code (as, presumably, Windows has) for m= achine > > specific behaviour, will we end up with a constantly growing mess of co= de to > > handle them all, or will workarounds be phased out in favour of proper = fixes? > > > > I've uploaded the original binary dsdt, disassembled version (which I d= id > > using quite an old version of iasl) and fixed version to > > http://www.redbrick.dcu.ie/~exolon/dsdt , /dsdt.dsl and /fixed.dsl > > respectively. > > > > Here is the -U5 diff for summary. The fixes I used were all standard ex= cept > > for the Z00D problem. I found no references to Z00D in any of the table= s > > supplied by the machine, so using a fixed version uploaded to the dsdt > > repository, replaced them with Z00C. Robert Moore mentioned that these = values > > may get overwritten anyway and 0 would also have worked, so I suppose i= t > > doesn't matter. :) > > > > good luck, > > Ois=EDn > > > > ___ > > > > --- dsdt.dsl 2004-10-25 22:11:22.501511136 +0100 > > +++ fixed.dsl 2004-10-25 22:11:03.349422696 +0100 > > @@ -1,10 +1,10 @@ > > /* > > * Intel ACPI Component Architecture > > - * AML Disassembler version 20040715 > > + * AML Disassembler version 20030918 > > * > > - * Disassembly of dsdt, Mon Oct 25 22:11:22 2004 > > + * Disassembly of dsdt, Mon Aug 30 08:05:46 2004 > > */ > > DefinitionBlock ("DSDT.aml", "DSDT", 1, "PTLTD ", "650M", 100925440) > > { > > OperationRegion (P80G, SystemIO, 0x80, 0x01) > > Field (P80G, ByteAcc, NoLock, Preserve) > > @@ -19,11 +19,11 @@ > > FANR, 8, > > Offset (0x58), > > F1CR, 8 > > } > > > > - Scope (_PR) > > + Scope (\_PR) > > { > > Processor (CPU0, 0x00, 0x00008010, 0x06) {} > > } > > > > Name (_S0, Package (0x02) > > @@ -50,11 +50,11 @@ > > Method (_PIC, 1, NotSerialized) > > { > > Store (Arg0, PICF) > > } > > > > - Scope (_SB) > > + Scope (\_SB) > > { > > Name (OSTB, Ones) > > Name (FWSO, "FWSO") > > Name (ECEN, 0x00) > > Name (ACST, 0x01) > > @@ -838,10 +838,11 @@ > > { > > Notify (VGA, 0x80) > > Return (0x00) > > } > > } > > + Return (0x00) > > } > > > > Method (USTA, 0, NotSerialized) > > { > > If (LEqual (\_SB.PCI0.LPCB.Z000, 0x00)) > > @@ -3425,12 +3426,12 @@ > > " " > > }) > > Name (PBST, Package (0x04) > > { > > 0x00, > > - Z00D, > > - Z00D, > > + Z00C, > > + Z00C, > > 0x2710 > > }) > > Name (ERRC, 0x00) > > Name (_PCL, Package (0x01) > > { > > @@ -3719,10 +3720,11 @@ > > } > > } > > } > > > > Decrement (Local1) > > + Return (0x0) > > } > > } > > > > Scope (\_TZ) > > { > > @@ -3829,13 +3831,14 @@ > > > > If (LEqual (Arg0, 0x05)) > > { > > \_SB.PCI0.LPCB.PHSR (0x06, 0x00) > > } > > + Return(Package(2){0, 0}) > > } > > > > - Scope (_GPE) > > + Scope (\_GPE) > > { > > Method (_L17, 0, NotSerialized) > > { > > Notify (\_SB.LID, 0x80) > > } > > > > > > > ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click