From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E720C00528 for ; Tue, 1 Aug 2023 18:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbjHAS3w (ORCPT ); Tue, 1 Aug 2023 14:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbjHAS3v (ORCPT ); Tue, 1 Aug 2023 14:29:51 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 296241FFC for ; Tue, 1 Aug 2023 11:29:40 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fe1d462762so24398625e9.0 for ; Tue, 01 Aug 2023 11:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690914578; x=1691519378; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P5ZgJY5V+lo4A+wauiGyF7FGynGi+N7roRkZKmsI0AM=; b=eT2gdrPCtxsywlMIzI0TJTR9wixsxeRfVWlJ3BZYPS8d2A4Wauy/Buvv0XyiqEXPL8 wSj9acw6cTiJ6TFtLC0bidkO5jKw0nX1nF1b2h33y3ITkSmbqQ6vV1I4Eks2octUl9jc GZbqNMMiD9+wJoysKKB1omyJkZgN0CevVnP/oA208funS7zPZkVEDa9CcWejL8AzC3rJ mQ9pOgCQVlFeKabtlLhKlZP31oVmsvGM1Bx8sWee13rRd/O6zsBNOkAOpiqM+dxhX2Qi 5iCk1af131QanFGOVh+/qeuX4YDmmGOGUlQfu+8/7/7FiaE6fuPJjAbHHzPzENoLOP7X I08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690914578; x=1691519378; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P5ZgJY5V+lo4A+wauiGyF7FGynGi+N7roRkZKmsI0AM=; b=MmIHWme0b4hA+6aM67eHcapWiVu31QtjuC1p55uDRncQbbX4mhcsCrveNcrZWaY0bD OY8Fwn6l3wTWVkQFAdAhuhBbcGkrj/ct/SpVpXBHObOFYZFPcikQ46ibDCZaBwC+mS7J dCA6AObGsr7TEgkkMwqlJRyuzRf/tcaZi6CyDHi96FBHOE0ieLkJ+XN/zdK7p1MXSr9H Zuw5f6To9Gn6pXL563RO6bYmTq1GgtgCcJ5jnXxkPhCVUUC9O4v0UMLd8UPCrcmCq64d DRFWzknZ6qBfUKsNAvOA3AkbF+d1H2qUMvsLxzEXaUBAyb9fKC+ChkyN62EBs4Y12iBO 9Ccg== X-Gm-Message-State: ABy/qLZ4roXOw6+i/VQeY5eqLdrq1i+fX0LbqCx60ej2XEoqUSbqoutE aRTV4vaphFau1Ovcf12ARSDifQ== X-Google-Smtp-Source: APBJJlGUPVRlf5YX550xqXJIcw2gB32dk1dhHfelMrwI3HdnHxIp01OWrQLT5vrnjc1FZrNabpYHLA== X-Received: by 2002:a7b:cb88:0:b0:3fc:f9c:a3e6 with SMTP id m8-20020a7bcb88000000b003fc0f9ca3e6mr3096943wmi.9.1690914578528; Tue, 01 Aug 2023 11:29:38 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id c16-20020a7bc010000000b003fbb06af219sm14355016wmb.32.2023.08.01.11.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 11:29:38 -0700 (PDT) Message-ID: <8ea6d9b1-f8a5-a899-ea30-7ec5d40a0c26@linaro.org> Date: Tue, 1 Aug 2023 20:29:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/8] thermal: core: Do not handle trip points with invalid temperature Content-Language: en-US To: "Rafael J. Wysocki" , Linux ACPI Cc: LKML , Linux PM , Michal Wilczynski , Zhang Rui , Srinivas Pandruvada References: <13318886.uLZWGnKmhe@kreacher> <12254967.O9o76ZdvQC@kreacher> <4822145.GXAFRqVoOG@kreacher> From: Daniel Lezcano In-Reply-To: <4822145.GXAFRqVoOG@kreacher> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 25/07/2023 14:06, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Trip points with temperature set to THERMAL_TEMP_INVALID are as good as > disabled, so make handle_thermal_trip() ignore them. > > Signed-off-by: Rafael J. Wysocki > --- > > v2 -> v3: No changes. > > v1 -> v2: No changes. > > --- > drivers/thermal/thermal_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux-pm/drivers/thermal/thermal_core.c > =================================================================== > --- linux-pm.orig/drivers/thermal/thermal_core.c > +++ linux-pm/drivers/thermal/thermal_core.c > @@ -348,7 +348,8 @@ static void handle_thermal_trip(struct t > struct thermal_trip trip; > > /* Ignore disabled trip points */ > - if (test_bit(trip_id, &tz->trips_disabled)) > + if (test_bit(trip_id, &tz->trips_disabled) || > + trip.temperature == THERMAL_TEMP_INVALID) > return; This will set the temperature to THERMAL_TEMP_INVALID at each thermal zone update. It would make more sense to set it when setting the disabled bit at init time, no? But is that something we really want to do ? The trip point will be reordered due to the temperature change (-273°C) -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog