Re: [PATCH v2 00/20] libnd: non-volatile memory device support

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Tuesday, April 28, 2015 06:22:05 PM Dan Williams wrote:
> On Tue, Apr 28, 2015 at 5:25 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Tuesday, April 28, 2015 02:24:12 PM Dan Williams wrote:
> >> Changes since v1 [1]: Incorporates feedback received prior to April 24.
> >>

[cut]

> >
> > I'm wondering what's wrong with CCing all of the series to linux-acpi?
> >
> > Is there anything in it that the people on that list should not see, by any
> > chance?
> 
> linux-acpi may not care about the dimm-metadata labeling patches that
> are completely independent of ACPI, but might as well include
> linux-acpi on the whole series at this point.

I've gone through the ACPI-related patches in this series (other than [2/20]
that I've commented directly) and while I haven't found anything horrible in
them, I don't quite feel confident enough to ACK them.

What I'm really missing in this series is a design document describing all that
from a high-level perspective and making it clear where all of the pieces go
and what their respective roles are.  Also reordering the series to introduce
the nd subsystem to start with and then its users might help here.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.