From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE" Date: Thu, 04 Apr 2013 23:00:57 +0200 Message-ID: <9105435.faatoZyPxO@vostro.rjw.lan> References: <1363689661.1390.9.camel@x61.thuisdomein> <3588021.V98D5VToQr@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: Received: from hydra.sisk.pl ([212.160.235.94]:51444 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761409Ab3DDUxU (ORCPT ); Thu, 4 Apr 2013 16:53:20 -0400 In-Reply-To: <3588021.V98D5VToQr@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lv Zheng Cc: Paul Bolle , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Tuesday, March 26, 2013 02:34:25 PM Rafael J. Wysocki wrote: > On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote: > > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its > > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was > > removed from that header in v3.8, with commit > > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged > > acmacros.h divergences."). That commit did not explain why that macro > > was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed > > too, as it is unused. > > Lv, can you please comment here? Lv, I'm still waiting for your comment regarding the commit mentioned above. Thanks, Rafael > > Signed-off-by: Paul Bolle > > --- > > Eyeball tested. > > > > drivers/acpi/Kconfig | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > > index 92ed969..006b714 100644 > > --- a/drivers/acpi/Kconfig > > +++ b/drivers/acpi/Kconfig > > @@ -298,14 +298,6 @@ config ACPI_DEBUG > > Documentation/kernel-parameters.txt to control the type and > > amount of debug output. > > > > -config ACPI_DEBUG_FUNC_TRACE > > - bool "Additionally enable ACPI function tracing" > > - default n > > - depends on ACPI_DEBUG > > - help > > - ACPI Debug Statements slow down ACPI processing. Function trace > > - is about half of the penalty and is rarely useful. > > - > > config ACPI_PCI_SLOT > > bool "PCI slot detection driver" > > depends on SYSFS > > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.