Re: [PATCH 1/1] ACPI: video: Add Toshiba Satellite/Portege Z830 quirk

[Hans de Goede <hdegoede@redhat.com>]

hI,

On 8/27/22 13:23, Arvid Norlander wrote:
> Hi,
> 
> On 2022-08-26 13:46, Hans de Goede wrote:
>> Hi All,
>>
>> [...]
>>
>> Arvid, I wonder if instead of using disable_backlight_sysfs_if
>> you can try:
>>
>> 0. Remove disable_backlight_sysfs_if from cmdline / quirk
>> 1. Adding acpi_backlight=native to the kernel commandline
>> 2. In toshiba_acpi_resume() add a HCI_PANEL_POWER_ON PANEL_ON
>>
>> and see if that also fixes things ?
>>
> Yes, this works.

Great, thank you for testing this!

In hindsight the disable_backlight_sysfs_if flag was a mistake
and I should have fixed this differently (I wrote the code adding
that flag).  And now it is sorta getting in the way of cleaning
up the backlight handling. So IMHO removing disable_backlight_sysfs_if
is the best thing to do here.

> I do not have a patch for this (I assume it
> would involve creating quirk tables, checking for support for
> HCI_PANEL_POWER_ON, etc). I simply hard coded the call in for
> the test. I very much doubt I will have time to code this in
> the near future as well.

No problem I will prepare a patch series for you to test. Note
this will be on top of my other backlight cleanups, so I
will just send you an email pointing to a git branch to tes,
I hope this will be ok?

> However, do we know what the other Toshiba's that need this
> quirk also supports HCI_PANEL_POWER_ON? I obviously can only
> test the Z830 that I own.

It seems that all models which need this are all from the same
generation so I would expect the same fix to work. If I get
regression reports from users after my cleanup series lands
I can then take a closer look at the DSDT tables of the
other models if necessary.

Regards,

Hans




> 
>> If that is the case then we can:
>>
>> 1. Move the DMI quirks for disable_backlight_sysfs_if
>>    from acpi_video.c to video_detect.c to force native
>>    mode by quirk
>> 2. Add the DMI table with the models needing this to
>>    toshiba_acpi.c and then based on that call
>>    HCI_PANEL_POWER_ON PANEL_ON on resume from there
>> 3. Since there are no more quirks using it, remove the
>>    disable_backlight_sysfs_if hack / workaround from
>>    acpi_video.c
>>
>> This will give a nice-cleanup of the generic acpi_video.c
>> code moving the toshiba specific fixup to toshiba_acpi
>> where it really belongs.
>>
>> Regards,
>>
>> Hans
>>
>>
> 
> Best regards,
> Arvid Norlander
>