From: Randy Dunlap <rdunlap@infradead.org>
To: Danilo Krummrich <dakr@kernel.org>,
gregkh@linuxfoundation.org, rafael@kernel.org,
andriy.shevchenko@linux.intel.com, djrscally@gmail.com,
heikki.krogerus@linux.intel.com, sakari.ailus@linux.intel.com,
brgl@kernel.org, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, driver-core@lists.linux.dev
Subject: Re: [PATCH] fwnode: add missing kernel-doc for struct fwnode_operations members
Date: Mon, 27 Jul 2026 13:41:09 -0700 [thread overview]
Message-ID: <94be2b84-e142-4e49-9263-1440039ff72a@infradead.org> (raw)
In-Reply-To: <20260727202748.2232253-1-dakr@kernel.org>
On 7/27/26 1:27 PM, Danilo Krummrich wrote:
> Document the four undocumented struct members in
> struct fwnode_operations: device_dma_supported, device_get_dma_attr,
> iomap, and irq_get.
>
> This avoids kernel-doc warnings once include/linux/fwnode.h is included
> in the driver-api infrastructure documentation.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> include/linux/fwnode.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 4e86e6990d28..a9dcaf7e7076 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -117,6 +117,8 @@ struct fwnode_reference_args {
> * @put: Put a reference to an fwnode.
> * @device_is_available: Return true if the device is available.
> * @device_get_match_data: Return the device driver match data.
> + * @device_dma_supported: Return true if DMA is supported.
> + * @device_get_dma_attr: Return the device DMA attribute.
> * @property_present: Return true if a property is present.
> * @property_read_bool: Return a boolean property value.
> * @property_read_int_array: Read an array of integer properties. Return zero on
> @@ -134,6 +136,8 @@ struct fwnode_reference_args {
> * endpoint node.
> * @graph_get_port_parent: Return the parent node of a port node.
> * @graph_parse_endpoint: Parse endpoint for port and endpoint id.
> + * @iomap: Map the I/O memory of a given index for a fwnode.
> + * @irq_get: Get the IRQ of a given index for a fwnode.
> * @add_links: Create fwnode links to all the suppliers of the fwnode. Return
> * zero on success, a negative error code otherwise.
> */
--
~Randy
next prev parent reply other threads:[~2026-07-27 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 20:27 [PATCH] fwnode: add missing kernel-doc for struct fwnode_operations members Danilo Krummrich
2026-07-27 20:41 ` Randy Dunlap [this message]
2026-07-28 8:05 ` Sakari Ailus
2026-07-28 8:38 ` Bartosz Golaszewski
2026-07-30 14:24 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94be2b84-e142-4e49-9263-1440039ff72a@infradead.org \
--to=rdunlap@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox