public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* tg3 ethernet not coming back properly after S3 suspend on Dell M70
@ 2005-06-08 21:26 Vladimir Vukicevic
  0 siblings, 0 replies; 8+ messages in thread
From: Vladimir Vukicevic @ 2005-06-08 21:26 UTC (permalink / raw)
  To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

I've been trying to get S3 suspend working on my Dell Precision M70
without much success for the past few weeks.  This is all now with
2.6.12-rc6, with Jens Axboe's patch for SATA suspend (as the machine
has a SATA interface and uses ata_piix).

I tried Shaohua's S3 "test tool" and gave it a shot -- with it I'm
able to go through a suspend/resume cycle with no problems.  Without
it, the machine locks up after unsuspend (after we're back in kernel
code) with the nvidia driver loaded, and is otherwise unstable without
the nvidia driver loaded.  In particular, the ethernet device is
completely screwed after coming out of unsuspend.  lspci shows (after
unsuspend):

02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5751
Gigabit Ethernet PCI Express (rev ff) (prog-if ff)
        !!! Unknown header type 7f

and lspci -x reports the entire config space coming back as 0xff.

This does not happen with the fake-S3 test patch.  The device tree, as
reported by lspci -t for this device looks like:

-[0000:00]-+-1c.0-[0000:02]----00.0

00:1c.0 PCI bridge: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) PCI Express Port 1 (rev 03)

The other device that's not coming up right is the video hardware, and
it's on the "PCI Express Root Port".  All the PCI (not PCI Express)
devices going through a PCI bridge seem to come back through fine, as
do USB and other bits.  Just the two devices on the PCI Express bus
seem screwed up post-resume, though lspci is able to read the nvidia
device's config space post-resume.

Any ideas where to start looking for a cause?  I figure fixing the tg3
issue should help track down the overall problem.

Thanks,
    - Vlad


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: tg3 ethernet not coming back properly after S3 suspend on Dell M70
@ 2005-06-09  2:17 Li, Shaohua
       [not found] ` <16A54BF5D6E14E4D916CE26C9AD305750239C2EB-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Li, Shaohua @ 2005-06-09  2:17 UTC (permalink / raw)
  To: Vladimir Vukicevic, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

>
>I've been trying to get S3 suspend working on my Dell Precision M70
>without much success for the past few weeks.  This is all now with
>2.6.12-rc6, with Jens Axboe's patch for SATA suspend (as the machine
>has a SATA interface and uses ata_piix).
>
>I tried Shaohua's S3 "test tool" and gave it a shot -- with it I'm
>able to go through a suspend/resume cycle with no problems.  Without
>it, the machine locks up after unsuspend (after we're back in kernel
>code) with the nvidia driver loaded, and is otherwise unstable without
>the nvidia driver loaded.  In particular, the ethernet device is
>completely screwed after coming out of unsuspend.  lspci shows (after
>unsuspend):
>
>02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5751
>Gigabit Ethernet PCI Express (rev ff) (prog-if ff)
>        !!! Unknown header type 7f
>
>and lspci -x reports the entire config space coming back as 0xff.
>
>This does not happen with the fake-S3 test patch.  The device tree, as
>reported by lspci -t for this device looks like:
>
>-[0000:00]-+-1c.0-[0000:02]----00.0
>
>00:1c.0 PCI bridge: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
>Family) PCI Express Port 1 (rev 03)
>
>The other device that's not coming up right is the video hardware, and
>it's on the "PCI Express Root Port".  All the PCI (not PCI Express)
>devices going through a PCI bridge seem to come back through fine, as
>do USB and other bits.  Just the two devices on the PCI Express bus
>seem screwed up post-resume, though lspci is able to read the nvidia
>device's config space post-resume.
>
>Any ideas where to start looking for a cause?  I figure fixing the tg3
>issue should help track down the overall problem.
>
Is the PCI express bridge's config space ok? Particularly, the bus
number registers. And can you track down if the tg3 resume routine
returns ok?

Thanks,
Shaohua


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: tg3 ethernet not coming back properly after S3 suspend on Dell M70
@ 2005-06-09 11:10 Li, Shaohua
       [not found] ` <16A54BF5D6E14E4D916CE26C9AD30575023E30BC-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Li, Shaohua @ 2005-06-09 11:10 UTC (permalink / raw)
  To: Vladimir Vukicevic; +Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

Hi,
>> >
>> >I've been trying to get S3 suspend working on my Dell Precision M70
>> >without much success for the past few weeks.  This is all now with
>> >2.6.12-rc6, with Jens Axboe's patch for SATA suspend (as the machine
>> >has a SATA interface and uses ata_piix).
>> > [ ... ]
>> >Any ideas where to start looking for a cause?  I figure fixing the
tg3
>> >issue should help track down the overall problem.
>> >
>> Is the PCI express bridge's config space ok? Particularly, the bus
>> number registers. And can you track down if the tg3 resume routine
>> returns ok?
>
>Hmm.. the config space doesn't look ok to me at all; I've attached the
>before and after suspend lspci -vv output for diffing, because I could
>easily be drawing the wrong conclusions here.  Some things I noticed:
>
>Before suspend:
>
>00:1c.0 PCI bridge: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
>Family) PCI Express Port 1 (rev 03) (prog-if 00 [Normal decode])
>        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
>ParErr- Stepping- SERR- FastB2B-
>        Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
>        Memory behind bridge: dcf00000-dcffffff
>
>After resume, we lose the BusMaster flag (not just on this device, but
>on a few others), and the bus numbers and memory ranges change:
>        Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop-
>ParErr- Stepping- SERR- FastB2B- (lost BusMaster flag?)
>        Bus: primary=00, secondary=00, subordinate=00, sec-latency=0
>        I/O behind bridge: 00000000-00000fff
>        Memory behind bridge: 00000000-000fffff
>        Prefetchable memory behind bridge: 0000000000000000-
>0000000000000000
>
>The root PCIE port on which the nvidia sits goes through similar
>lossage... no memory range behind the bridge is reported after resume,
>and MSI's are reported as disabled where they were enabled before.
>
>I haven't been able to track down if the tg3 resume function completes
>as of yet; it's hit and miss whether the display gets restored after a
>resume (dpms/vbetool sometimes help, sometimes they don't), and with
>the tg3 module loaded I can only send commands through in bursts...
>will give it another few tries.
Not required testing tg3 driver now. If the bridge is broken, all
devices under it will be broken. Did you enable the PCIE port driver? I
suspect it's the cause, since default PCI resume routine can restore PCI
bridge's config space.

Thanks,
Shaohua


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2005-06-10  2:45 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-08 21:26 tg3 ethernet not coming back properly after S3 suspend on Dell M70 Vladimir Vukicevic
  -- strict thread matches above, loose matches on Subject: below --
2005-06-09  2:17 Li, Shaohua
     [not found] ` <16A54BF5D6E14E4D916CE26C9AD305750239C2EB-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-06-09  8:46   ` Vladimir Vukicevic
2005-06-09 11:10 Li, Shaohua
     [not found] ` <16A54BF5D6E14E4D916CE26C9AD30575023E30BC-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-06-09 18:06   ` Vladimir Vukicevic
     [not found]     ` <9540d0105060911066a4d4867-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-06-10  1:59       ` Shaohua Li
     [not found]         ` <1118368773.3860.3.camel-ECwVeV2eNyQD0+JXs3kMbRL4W9x8LtSr@public.gmane.org>
2005-06-10  2:28           ` Vladimir Vukicevic
     [not found]             ` <9540d0105060919283b48a35b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-06-10  2:45               ` Shaohua Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox