RE: tg3 ethernet not coming back properly after S3 suspendon Dell M70

RE: tg3 ethernet not coming back properly after S3 suspendon Dell M70

[Nguyen, Tom L]

On Thursday, June 09, 2005 7:45 PM Shaohua Li wrote:
> On Thu, 2005-06-09 at 19:28 -0700, Vladimir Vukicevic wrote:
> > On 6/9/05, Shaohua Li <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > > Please try below patch.
> > > 
> > > Long, is this patch ok to you? PCIE bridge itself requires to
> > > save/restore config space.
> > > 
> > > Thanks,
> > > Shaohua
> > > 
> > > 
> > > --- a/drivers/pci/pcie/portdrv_pci.c    2005-06-08
10:36:05.000000000 > > > +0800
> > > +++ b/drivers/pci/pcie/portdrv_pci.c    2005-06-10
09:34:55.760496584 > > > +0800
> > > @@ -69,11 +69,16 @@ static void pcie_portdrv_remove (struct
> > >  #ifdef CONFIG_PM
> > >  static int pcie_portdrv_suspend (struct pci_dev *dev,
pm_message_t 
> > > state)
> > > {
> > > -       return pcie_port_device_suspend(dev, state);
> > > +       int ret = pcie_port_device_suspend(dev, state);
> > > +       pci_save_state(dev);
> > > +       return ret;
> > >  }
> > >
> > > static int pcie_portdrv_resume (struct pci_dev *dev)
> > > {
> > > +       pci_restore_state(dev);
> > > +       pci_enable_device(dev);
> > > +       pci_set_master(dev);
> > >        return pcie_port_device_resume(dev);
> > > }
> > > #endif
> > >
> > That patch did the trick!  All the devices seem to come back with
> > their config space identical to before the suspend.  I noticed that
> > pci_save_state/pci_restore_state only save 64 bytes of state -- I
did
> > a separate patch before I saw your mail that saved the full size of
> > the config space (based on dev->cfg_size) that also fixed things...
> > should the full config space size be saved, or is that not
necessary?
> Great! It's ideal to save/restore full size config, but there is no
> standard way to save full size config. Some config spaces can't be
> accessed in many cards, like a LPC bridge. They don't follow PCI
> standard.

This patch is great!

Thanks,
Long


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

RE: tg3 ethernet not coming back properly after S3 suspendon Dell M70

[Nguyen, Tom L]

On Thursday, June 09, 2005 7:00 PM Shaohua Li wrote:
> Long, is this patch ok to you? PCIE bridge itself requires to
> save/restore config space.

Great! Would you please also add saving/restoring MSI capability
structure if supported?

Thanks,
Long


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

Re: tg3 ethernet not coming back properly after S3 suspendon Dell M70

[Vasileios Gkanis]

I do not have a Dell and when I resume from suspend the monitor does not come 
on. I applied the patch, but it did not help. I also have a PCIE card and I 
have the CONFIG_PCIEBUSPORT enabled.
Do I need to unload the tg3 module, before I suspend the system?

Vasilis


On Friday 10 June 2005 01:17 pm, Nguyen, Tom L wrote:
> On Thursday, June 09, 2005 7:00 PM Shaohua Li wrote:
> > Long, is this patch ok to you? PCIE bridge itself requires to
> > save/restore config space.
>
> Great! Would you please also add saving/restoring MSI capability
> structure if supported?
>
> Thanks,
> Long
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you
> shotput a projector? How fast can you ride your desk chair down the office
> luge track? If you want to score the big prize, get to know the little guy.
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.  
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20

Re: tg3 ethernet not coming back properly after S3 suspendon Dell M70

[Vladimir Vukicevic]

On 6/10/05, Vasileios Gkanis <gkanis-4fMUIQ/vbHD2fBVCVOL8/A@public.gmane.org> wrote:
> I do not have a Dell and when I resume from suspend the monitor does not come
> on. I applied the patch, but it did not help. I also have a PCIE card and I
> have the CONFIG_PCIEBUSPORT enabled.
> Do I need to unload the tg3 module, before I suspend the system?

I think the PCIE video suspend issues are not related to the tg3
issues, though there may still be deeper PCIE suspend issues.  I still
cannot get my video to recover, though debugging is harder because the
nvidia binary module is involved, and it seems to set the monitor's
DPMS state to "off" when it goes to suspend.  So, when the system
resumes, DPMS is still "off", and something wedges before it ever gets
put back to "on", so I can't see how far I make it in the resume
process.  (Serial console doesn't seem to be that useful.)

     - Vlad


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

RE: tg3 ethernet not coming back properly after S3 suspendon Dell M70

[Li, Shaohua]

Hi Long,
>
>On Thursday, June 09, 2005 7:00 PM Shaohua Li wrote:
>> Long, is this patch ok to you? PCIE bridge itself requires to
>> save/restore config space.
>
>Great! Would you please also add saving/restoring MSI capability
structure
>if supported?
Ideally, we should call pci_enable/disable_msi/msix for suspend/resume,
but I have some troubles to save/restore the MSIx configs. The driver
doesn't record the msix_entries. Anyway, you are the expert, so it might
be up to you to add the MSI support.

Thanks,
Shaohua


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r