From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <rafael@kernel.org>, <robert.moore@intel.com>,
<linux-acpi@vger.kernel.org>,
<amadeuszx.slawinski@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH v3 2/4] ACPI: NHLT: Introduce acpi_gbl_nhlt
Date: Fri, 21 Jul 2023 14:44:42 +0200 [thread overview]
Message-ID: <95930a64-d7eb-7d88-d7ee-13a319674d77@intel.com> (raw)
In-Reply-To: <ZLpigtZ0ptwhhWEi@smile.fi.intel.com>
On 2023-07-21 12:48 PM, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 11:47:20AM +0200, Cezary Rojewski wrote:
>> While there is no strict limit to amount of NHLT tables present, usually
>> just the first one is utilized. To simplify implementation of sound
>> drivers, provide publicly accessible pointer. Accessing it after calling
>> acpi_nhlt_get_gbl_table() yields the first NHLT table met during the
>> scan.
...
>> @@ -594,6 +594,9 @@ config ACPI_PRMT
>
>> +config ACPI_NHLT
>
> Wouldn't be better to squeeze it to the most ordered piece of the file, so
> the list of the table support code files will be kinda ordered?
I may be wrong about this, but it seems that the driver/acpi/Kconfig
file does not list tables supported in any kind of ordered fashion. I'd
refrain from reordering the Kconfig in this very patch and rather have
such job done in a separate series instead.
> Otherwise looks good to me, FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
next prev parent reply other threads:[~2023-07-21 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:47 [PATCH v3 0/4] ACPI: NHLT: Access and query helpers Cezary Rojewski
2023-07-21 9:47 ` [PATCH v3 1/4] ACPI: NHLT: Device configuration access interface Cezary Rojewski
2023-07-21 9:47 ` [PATCH v3 2/4] ACPI: NHLT: Introduce acpi_gbl_nhlt Cezary Rojewski
2023-07-21 10:48 ` Andy Shevchenko
2023-07-21 12:44 ` Cezary Rojewski [this message]
2023-07-21 12:55 ` Andy Shevchenko
2023-07-21 13:18 ` Cezary Rojewski
2023-07-21 13:52 ` Andy Shevchenko
2023-07-21 9:47 ` [PATCH v3 3/4] ACPI: NHLT: Table manipulation helpers Cezary Rojewski
2023-07-21 9:47 ` [PATCH v3 4/4] ACPI: NHLT: Add query functions Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95930a64-d7eb-7d88-d7ee-13a319674d77@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox