From: "Alex G." <mr.nuke.me@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com,
tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com,
shiju.jose@huawei.com, zjzhang@codeaurora.org,
gengdongjiu@huawei.com, linux-kernel@vger.kernel.org,
alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org,
robert.moore@intel.com, erik.schmauss@intel.com,
Yazen Ghannam <yazen.ghannam@amd.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [RFC PATCH v2 3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal.
Date: Wed, 25 Apr 2018 12:27:59 -0500 [thread overview]
Message-ID: <96b6f27f-5e82-53f0-627f-85c2f31a095b@gmail.com> (raw)
In-Reply-To: <20180425171557.GC2597@pd.tnic>
On 04/25/2018 12:15 PM, Borislav Petkov wrote:
> On Wed, Apr 25, 2018 at 10:00:53AM -0500, Alex G. wrote:
>> Firmware-first.
>
> Ok, my guess was right.
>
>> We could probably use more of the native AER print functions, but that's
>> beyond the scope of this patch.
>
> No no, this does not belong in this patchset.
>
>> Like the exact thing that this patch series implements? :)
>
> Exact thing? I don't think so.
>
> No, your patchset is grafting some funky and questionable side-handler
> which gets to see the PCIe errors first, out-of-line and then it
> practically downgrades their severity outside of the error processing
> flow.
SURPRISE!!! This is a what vs how issue. I am keeping the what, and
working on the how that you suggested.
> What I've been telling you
It's coming (eventually). I'm trying to avoid pushing more than one
series per week.
(snip useful email context)
Hmmm.
Alex
next prev parent reply other threads:[~2018-04-25 17:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 21:58 [RFC PATCH v2 0/4] acpi: apei: Improve error handling with firmware-first Alexandru Gagniuc
2018-04-16 21:59 ` [RFC PATCH v2 1/4] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error Alexandru Gagniuc
2018-04-17 9:36 ` Borislav Petkov
2018-04-17 16:43 ` Alex G.
2018-04-16 21:59 ` [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc Alexandru Gagniuc
2018-04-18 17:52 ` Borislav Petkov
2018-04-19 14:19 ` Alex G.
2018-04-19 14:30 ` Borislav Petkov
2018-04-19 14:57 ` Alex G.
2018-04-19 15:29 ` Borislav Petkov
2018-04-19 15:46 ` Alex G.
2018-04-19 16:40 ` Borislav Petkov
2018-04-16 21:59 ` [RFC PATCH v2 3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal Alexandru Gagniuc
2018-04-18 17:54 ` Borislav Petkov
2018-04-19 14:57 ` Alex G.
2018-04-19 15:35 ` James Morse
2018-04-19 16:27 ` Alex G.
2018-04-19 15:40 ` Borislav Petkov
2018-04-19 16:26 ` Alex G.
2018-04-19 16:45 ` Borislav Petkov
2018-04-19 17:40 ` Alex G.
2018-04-19 19:03 ` Borislav Petkov
2018-04-19 22:55 ` Alex G.
2018-04-22 10:48 ` Borislav Petkov
2018-04-24 4:19 ` Alex G.
2018-04-25 14:01 ` Borislav Petkov
2018-04-25 15:00 ` Alex G.
2018-04-25 17:15 ` Borislav Petkov
2018-04-25 17:27 ` Alex G. [this message]
2018-04-25 17:39 ` Borislav Petkov
2018-04-16 21:59 ` [RFC PATCH v2 4/4] acpi: apei: Warn when GHES marks correctable errors as "fatal" Alexandru Gagniuc
2018-04-18 17:54 ` Borislav Petkov
2018-04-19 15:11 ` Alex G.
2018-04-19 15:46 ` Borislav Petkov
2018-04-25 20:39 ` [RFC PATCH v3 0/3] acpi: apei: Improve PCIe error handling with firmware-first Alexandru Gagniuc
2018-04-25 20:39 ` [RFC PATCH v3 1/3] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error Alexandru Gagniuc
2018-04-25 20:39 ` [RFC PATCH v3 2/3] acpi: apei: Do not panic() on PCIe errors reported through GHES Alexandru Gagniuc
2018-04-26 11:19 ` Borislav Petkov
2018-04-26 17:44 ` Alex G.
2018-04-25 20:39 ` [RFC PATCH v3 3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" Alexandru Gagniuc
2018-04-26 11:20 ` Borislav Petkov
2018-04-26 17:47 ` Alex G.
2018-04-26 18:03 ` Borislav Petkov
2018-05-02 19:10 ` Pavel Machek
2018-05-02 19:29 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96b6f27f-5e82-53f0-627f-85c2f31a095b@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=ard.biesheuvel@linaro.org \
--cc=austin_bolen@dell.com \
--cc=bp@alien8.de \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=shiju.jose@huawei.com \
--cc=shyam_iyer@dell.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=yazen.ghannam@amd.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).