From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20602C04AB6 for ; Fri, 31 May 2019 09:10:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F20B026679 for ; Fri, 31 May 2019 09:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbfEaJKe (ORCPT ); Fri, 31 May 2019 05:10:34 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:48528 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfEaJKe (ORCPT ); Fri, 31 May 2019 05:10:34 -0400 Received: from 79.184.255.225.ipv4.supernova.orange.pl (79.184.255.225) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.213) id c2b0c10174bd02aa; Fri, 31 May 2019 11:10:31 +0200 From: "Rafael J. Wysocki" To: Hans de Goede , Heikki Krogerus Cc: Greg Kroah-Hartman , Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v4 13/16] platform/x86: intel_cht_int33fe: Provide software nodes for the devices Date: Fri, 31 May 2019 11:10:31 +0200 Message-ID: <9821910.95WSKUoubE@kreacher> In-Reply-To: <7468b83c-3d75-b43f-559b-68b3140a89e9@redhat.com> References: <20190522105113.11153-1-heikki.krogerus@linux.intel.com> <20190522105113.11153-14-heikki.krogerus@linux.intel.com> <7468b83c-3d75-b43f-559b-68b3140a89e9@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wednesday, May 29, 2019 11:30:58 AM CEST Hans de Goede wrote: > Hi, > > On 5/22/19 12:51 PM, Heikki Krogerus wrote: > > Software nodes provide two features that we will need later. > > 1) Software nodes can have references to other software nodes. > > 2) Software nodes can exist before a device entry is created. > > > > Signed-off-by: Heikki Krogerus > > --- > > drivers/platform/x86/intel_cht_int33fe.c | 53 ++++++++++++++++++++---- > > 1 file changed, 45 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c > > index 4ab47d6df413..a4ebd1d6b5b6 100644 > > --- a/drivers/platform/x86/intel_cht_int33fe.c > > +++ b/drivers/platform/x86/intel_cht_int33fe.c > > @@ -27,6 +27,13 @@ > > > > #define EXPECTED_PTYPE 4 > > > > +enum { > > + INT33FE_NODE_FUSB302, > > + INT33FE_NODE_MAX17047, > > + INT33FE_NODE_PI3USB30532, > > + INT33FE_NODE_MAX, > > +}; > > + > > struct cht_int33fe_data { > > struct i2c_client *max17047; > > struct i2c_client *fusb302; > > @@ -72,8 +79,13 @@ static const struct property_entry max17047_props[] = { > > > > static const struct property_entry fusb302_props[] = { > > PROPERTY_ENTRY_STRING("linux,extcon-name", "cht_wcove_pwrsrc"), > > - PROPERTY_ENTRY_U32("fcs,max-sink-microvolt", 12000000), > > - PROPERTY_ENTRY_U32("fcs,max-sink-microamp", 3000000), > > + { } > > +}; > > + > > +static const struct software_node nodes[] = { > > + { "fusb302", NULL, fusb302_props }, > > + { "max17047", NULL, max17047_props }, > > + { "pi3usb30532" }, > > { } > > }; > > > > @@ -82,14 +94,17 @@ cht_int33fe_register_max17047(struct device *dev, struct cht_int33fe_data *data) > > { > > struct i2c_client *max17047 = NULL; > > struct i2c_board_info board_info; > > + struct fwnode_handle *fwnode; > > int ret; > > > > + fwnode = software_node_fwnode(&nodes[INT33FE_NODE_MAX17047]); > > + if (!fwnode) > > + return -ENODEV; > > + > > i2c_for_each_dev(&max17047, cht_int33fe_check_for_max17047); > > if (max17047) { > > /* Pre-existing i2c-client for the max17047, add device-props */ > > - ret = device_add_properties(&max17047->dev, max17047_props); > > - if (ret) > > - return ret; > > + max17047->dev.fwnode->secondary = fwnode; > > I believe that you should do: > fwnode->secondary = ERR_PTR(-ENODEV); > cht_int33fe_setup_dp > Before this call, as you are doing in the cht_int33fe_setup_dp function. So I'm inclined to defer this patch until it is improved and queue up the rest of the series. I can fix up the typo in the [15/16] while handling it.