From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Lee Chun-Yi" <jlee@suse.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Ike Panhc" <ike.pan@canonical.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Alexis Belmonte" <alexbelm48@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
<platform-driver-x86@vger.kernel.org>,
"open list:THINKPAD ACPI EXTRAS DRIVER"
<ibm-acpi-devel@lists.sourceforge.net>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Armin Wolf" <W_Armin@gmx.de>
Subject: Re: [PATCH v9 19/22] ACPI: platform_profile: Notify class device from platform_profile_notify()
Date: Thu, 5 Dec 2024 16:24:59 +0200 (EET) [thread overview]
Message-ID: <99d8a69d-2d61-28c3-7dd4-273b24d32727@linux.intel.com> (raw)
In-Reply-To: <20241202055031.8038-20-mario.limonciello@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
On Sun, 1 Dec 2024, Mario Limonciello wrote:
> When a driver has called platform_profile_notify() both the legacy sysfs
> interface and the class device should be notified as userspace may listen
> to either.
>
> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v8:
> * notify only one dev
> ---
> drivers/acpi/platform_profile.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index 16746d9b9aa7c..289b5d43638ae 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -401,6 +401,9 @@ void platform_profile_notify(struct platform_profile_handler *pprof)
> {
> if (!cur_profile)
> return;
> + scoped_cond_guard(mutex_intr, return, &profile_lock) {
> + _notify_class_profile(pprof->class_dev, NULL);
> + }
> sysfs_notify(acpi_kobj, NULL, "platform_profile");
> }
> EXPORT_SYMBOL_GPL(platform_profile_notify);
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-12-05 14:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 5:50 [PATCH v9 00/22] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 01/22] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 02/22] platform/x86/dell: dell-pc: Create platform device Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 03/22] ACPI: platform_profile: Add device pointer into platform profile handler Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 04/22] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 05/22] ACPI: platform_profile: Pass the profile handler into platform_profile_notify() Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 06/22] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 07/22] ACPI: platform_profile: Move matching string for new profile out of mutex Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 08/22] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 09/22] ACPI: platform_profile: Use `scoped_cond_guard` Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 10/22] ACPI: platform_profile: Create class for ACPI platform profile Mario Limonciello
2024-12-04 13:41 ` Ilpo Järvinen
2024-12-02 5:50 ` [PATCH v9 11/22] ACPI: platform_profile: Add name attribute to class interface Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 12/22] ACPI: platform_profile: Add choices attribute for " Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 13/22] ACPI: platform_profile: Add profile " Mario Limonciello
2024-12-05 11:40 ` Ilpo Järvinen
2024-12-02 5:50 ` [PATCH v9 14/22] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 15/22] ACPI: platform_profile: Only show profiles common for all handlers Mario Limonciello
2024-12-05 11:47 ` Ilpo Järvinen
2024-12-02 5:50 ` [PATCH v9 16/22] ACPI: platform_profile: Add concept of a "custom" profile Mario Limonciello
2024-12-05 11:50 ` Ilpo Järvinen
2024-12-02 5:50 ` [PATCH v9 17/22] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-12-05 12:07 ` Ilpo Järvinen
2024-12-02 5:50 ` [PATCH v9 18/22] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-12-05 14:22 ` Ilpo Järvinen
2024-12-05 14:46 ` Mario Limonciello
2024-12-05 15:22 ` Ilpo Järvinen
2024-12-05 15:35 ` Mario Limonciello
2024-12-02 5:50 ` [PATCH v9 19/22] ACPI: platform_profile: Notify class device from platform_profile_notify() Mario Limonciello
2024-12-05 14:24 ` Ilpo Järvinen [this message]
2024-12-02 5:50 ` [PATCH v9 20/22] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-12-05 14:27 ` Ilpo Järvinen
2024-12-02 5:50 ` [PATCH v9 21/22] platform/x86/amd: pmf: Drop all quirks Mario Limonciello
2024-12-05 14:30 ` Ilpo Järvinen
2024-12-02 5:50 ` [PATCH v9 22/22] Documentation: Add documentation about class interface for platform profiles Mario Limonciello
2024-12-05 14:33 ` Ilpo Järvinen
2024-12-02 14:31 ` [PATCH v9 00/22] Add support for binding ACPI platform profile to multiple drivers Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99d8a69d-2d61-28c3-7dd4-273b24d32727@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=W_Armin@gmx.de \
--cc=aichao@kylinos.cn \
--cc=alexbelm48@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=luzmaximilian@gmail.com \
--cc=mario.limonciello@amd.com \
--cc=matthew.schwartz@linux.dev \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=soyer@irl.hu \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox