Re: [PATCH 1/1] ACPI/nfit: correct the badrange to be reported in nfit_handle_mce()

Leizhen (ThunderTown)
2020-11-19T01:56:22Z

On 2020/11/19 4:50, Verma, Vishal L wrote:
> On Wed, 2020-11-18 at 16:41 +0800, Zhen Lei wrote:
>> The badrange to be reported should always cover mce->addr.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> drivers/acpi/nfit/mce.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ah good find, agreed with Dan that this is stable material.
> Minor nit, I'd recommend rewording the subject line to something like:
>
> "acpi/nfit: fix badrange insertion in nfit_handle_mce()"

OK, I will send v2.

>
> Otherwise, looks good to me.
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
>>
>> diff --git a/drivers/acpi/nfit/mce.c b/drivers/acpi/nfit/mce.c
>> index ee8d9973f60b..053e719c7bea 100644
>> --- a/drivers/acpi/nfit/mce.c
>> +++ b/drivers/acpi/nfit/mce.c
>> @@ -63,7 +63,7 @@ static int nfit_handle_mce(struct notifier_block *nb, unsigned long val,
>>
>> /* If this fails due to an -ENOMEM, there is little we can do */
>> nvdimm_bus_add_badrange(acpi_desc->nvdimm_bus,
>> - ALIGN(mce->addr, L1_CACHE_BYTES),
>> + ALIGN_DOWN(mce->addr, L1_CACHE_BYTES),
>> L1_CACHE_BYTES);
>> nvdimm_region_notify(nfit_spa->nd_region,
>> NVDIMM_REVALIDATE_POISON);
>