From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1250931E88A; Fri, 19 Sep 2025 16:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758298240; cv=none; b=Qei1hhRDJ9BeYJ5UZ6/F1UMugsYE8CPSSVruuA3Y5/XaFgb1OWWVBzQdzyjctNcC+CCG6FuN8gd73NFk7M99AALoqFlcKJ9cJMBfcBYJQqdg4DqfeAx6Kla/lUk40ZAkiKr6ks1YhU0mOEW+4ttB7Yb7SeWCxqnRDEXbqQr2EN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758298240; c=relaxed/simple; bh=mAOuEoindONrH7+HTWy4zMc8icBvloh1mIviQk8IvzA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=me2Ry2G74pFYrMDnJHkzLF+z4LCGYxO7YhLwovDPJrz9PIHeSgm55cE3G8Osoq/YApkHyCLTt2OIzAPduszRPsBPIyhjlzc0JbBrm1PtULt1C2/+KysAZPNqyTkV+oU5KoGHGMgEie14hHgqJzLwCmNjWtDTFaxtVkw7akkIvSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50743169E; Fri, 19 Sep 2025 09:10:30 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ECDCB3F66E; Fri, 19 Sep 2025 09:10:32 -0700 (PDT) Message-ID: <9e5b267d-3b4d-49bb-946c-dd501ca64e54@arm.com> Date: Fri, 19 Sep 2025 17:10:30 +0100 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/29] ACPI / PPTT: Stop acpi_count_levels() expecting callers to clear levels To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-3-james.morse@arm.com> <20250911114623.00007cd3@huawei.com> Content-Language: en-GB From: James Morse In-Reply-To: <20250911114623.00007cd3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jonathan, On 11/09/2025 11:46, Jonathan Cameron wrote: > On Wed, 10 Sep 2025 20:42:42 +0000 > James Morse wrote: > >> In acpi_count_levels(), the initial value of *levels passed by the >> caller is really an implementation detail of acpi_count_levels(), so it >> is unreasonable to expect the callers of this function to know what to >> pass in for this parameter. The only sensible initial value is 0, >> which is what the only upstream caller (acpi_get_cache_info()) passes. >> >> Use a local variable for the starting cache level in acpi_count_levels(), >> and pass the result back to the caller via the function return value. >> >> Gid rid of the levels parameter, which has no remaining purpose. >> >> Fix acpi_get_cache_info() to match. >> >> Suggested-by: Jonathan Cameron >> Signed-off-by: James Morse >> Reviewed-by: Lorenzo Pieralisi > Reviewed-by: Jonathan Cameron Thanks! James