From: Bjorn Helgaas <bhelgaas@google.com>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>,
Yijing Wang <wangyijing@huawei.com>
Subject: Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
Date: Thu, 21 May 2015 10:10:51 -0500 [thread overview]
Message-ID: <CAErSpo6kFfXd9gFuL86qQWcVN6NYe11Ps+SoAefz1z2md8j_tA@mail.gmail.com> (raw)
In-Reply-To: <1432216352-8016-1-git-send-email-hanjun.guo@linaro.org>
On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> list_head "list" in struct acpi_prt_entry was used to connect
> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
> Don't cache _PRT, and don't associate them with bus numbers),
> the list head for _PRT entries was removed, but left "list" in
> struct acpi_prt_entry which is useless and stale, remove it now.
Please use the canonical commit reference format, i.e.,
181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
with bus numbers")
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> CC: Yinghai Lu <yinghai@kernel.org>
> CC: Yijing Wang <wangyijing@huawei.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/acpi/pci_irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index b1def41..03e4b6c 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -44,7 +44,6 @@
> ACPI_MODULE_NAME("pci_irq");
>
> struct acpi_prt_entry {
> - struct list_head list;
> struct acpi_pci_id id;
> u8 pin;
> acpi_handle link;
> --
> 1.7.12.4
>
next prev parent reply other threads:[~2015-05-21 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:52 [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry Hanjun Guo
2015-05-21 15:10 ` Bjorn Helgaas [this message]
2015-05-21 15:17 ` Hanjun Guo
2015-05-21 15:21 ` Bjorn Helgaas
2015-05-21 15:53 ` Bjorn Helgaas
2015-05-22 11:04 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo6kFfXd9gFuL86qQWcVN6NYe11Ps+SoAefz1z2md8j_tA@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=hanjun.guo@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wangyijing@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).