From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [Bugfix v5] x86/PCI/ACPI: Fix regression caused by commit 63f1789ec716 Date: Wed, 29 Apr 2015 08:37:03 -0500 Message-ID: References: <1429499338-16967-1-git-send-email-jiang.liu@linux.intel.com> <3492366.RzMG5dcPfN@vostro.rjw.lan> <5540DD9C.9030707@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <5540DD9C.9030707@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jiang Liu Cc: "Rafael J. Wysocki" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "x86@kernel.org" , Len Brown , Lv Zheng , LKML , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org On Wed, Apr 29, 2015 at 8:33 AM, Jiang Liu wrote: > On 2015/4/29 21:20, Bjorn Helgaas wrote: >> On Tue, Apr 28, 2015 at 7:40 PM, Rafael J. Wysocki wrote: >>> On Monday, April 20, 2015 11:08:58 AM Jiang Liu wrote: >>>> + * >>>> + * Another possible solution is to explicitly filter out IO >>>> + * port[0xCF8-0xCFF]. >>>> + */ >>>> + res_flags = IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_IO_FIXED; >> >> 2) The usage of IORESOURCE_IO_FIXED here seems like a hack. It's not >> related to other existing use of IORESOURCE_IO_FIXED, and it's not >> intuitive that supplying IORESOURCE_MEM means "I want all the >> memory-type resources," but supplying IORESOURCE_IO_FIXED means "I >> *don't* want the fixed I/O-type resources." > > Yes, the IORESOURCE_IO_FIXED is a hack here. Then how about explicitly > filtering IOPORT [0xCF8-0xCFF] so we could avoid such a hack. I'm OK with that, although it should be in an arch-specific hook or something.