From: Bjorn Helgaas <bhelgaas@google.com>
To: Thomas Renninger <trenn@suse.de>
Cc: Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/5] ACPI processor: Avoid WARN message on processor driver removal
Date: Tue, 17 Jan 2012 07:41:59 -0700 [thread overview]
Message-ID: <CAErSpo7Sy4sd_QPWCwSoREyMpyt5yoxvVhOWsgy55hLZf0mMDw@mail.gmail.com> (raw)
In-Reply-To: <201201171525.15937.trenn@suse.de>
On Tue, Jan 17, 2012 at 7:25 AM, Thomas Renninger <trenn@suse.de> wrote:
> On Tuesday, January 17, 2012 12:02:39 PM Len Brown wrote:
>> On 11/17/2011 05:36 PM, Thomas Renninger wrote:
> ...
>
>> I think the old cold reads better than the new code,
>> since I don't have to guess what "acpi_idle_active" means...
> Sigh, Bjorn suggested it exactly the other way around.
> I don't mind which way, back to my original post half a year
> ago...
I don't care very much either way. I think I just thought it was
nicer for the driver to locally remember "I registered, therefore I
should unregister/init new CPUs." Apparently there can be several
idle drivers, and I don't know what happens if you register more than
one or what cpuidle_get_driver() means in that case.
Bjorn
next prev parent reply other threads:[~2012-01-17 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1321569421-46220-1-git-send-email-trenn@suse.de>
2011-11-17 22:36 ` [PATCH 1/5] ACPI processor: Do not export acpi_idle_driver in processor.h Thomas Renninger
2012-01-17 11:25 ` Len Brown
2012-01-17 14:08 ` Thomas Renninger
2011-11-17 22:36 ` [PATCH 2/5] ACPI processor: Avoid WARN message on processor driver removal Thomas Renninger
2012-01-17 11:02 ` Len Brown
2012-01-17 14:25 ` Thomas Renninger
2012-01-17 14:41 ` Bjorn Helgaas [this message]
2012-01-17 14:58 ` Thomas Renninger
2011-11-17 22:36 ` [PATCH 3/5] intel_idle: Split up and provide per CPU initialization func Thomas Renninger
2011-11-17 22:44 ` Thomas Renninger
2012-01-17 11:06 ` Len Brown
2012-01-17 13:26 ` Thomas Renninger
2012-01-17 16:10 ` Thomas Renninger
2011-11-17 22:37 ` [PATCH 4/5] ACPI processor: Fix error path, also remove sysdev link Thomas Renninger
2011-11-17 22:37 ` [PATCH 5/5] ACPI processor: Remove unneeded variable passed by acpi_processor_hotadd_init Thomas Renninger
2012-01-17 11:10 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo7Sy4sd_QPWCwSoREyMpyt5yoxvVhOWsgy55hLZf0mMDw@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).