From: Naresh Bhat <naresh.bhat@linaro.org>
To: "Anderson, Brandon" <brandon.anderson@amd.com>
Cc: "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
linux-acpi@vger.kernel.org, lenb@kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Hanjun Guo <hanjun.guo@linaro.org>,
Graeme Gregory <graeme.gregory@linaro.org>,
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
Subject: Re: [RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource
Date: Tue, 22 Oct 2013 13:50:32 +0530 [thread overview]
Message-ID: <CAFoFrHY0vR5T0rX80UHQWcuAUPQdshz3TrQ5Eh3F7utrV9Yutg@mail.gmail.com> (raw)
In-Reply-To: <1382402029-13381-1-git-send-email-brandon.anderson@amd.com>
Hi Anderson,
The patches applied, compiled (except there was a conflict in the last
patch "Hack clock names to get prototype running"). Can you please
post the ASL code changes patch ? looks like ASL changes are different
from what we have written originally.
-Naresh
On 22 October 2013 06:03, <brandon.anderson@amd.com> wrote:
> From: Brandon Anderson <brandon.anderson@amd.com>
>
> This is a proposal for ACPI driver probing of the ARM AMBA devices currently listed under ‘iofpga’ in the RTSM dts file. The main addition is drivers/amba/acpi.c which fits the role of an AMBA bus ‘connector resource’ for ACPI using struct amba_device.
>
> I have not yet figured out the implementation details regarding clocks (handled in the dts file with clock-names). However, I have included a proposed ASL format for clock information in the DSDT example below. With the last patch that hacks the clock info, this prototype will run on the Foundation and RTSM models.
>
> These patches require Hanjun’s fixed-clock patches to be applied first on top of a Linaro ACPI kernel: https://git.linaro.org/gitweb?p=arm/acpi/leg-kernel.git;a=summary
>
> Please comment on both the concept and the implementation.
>
> Brandon Anderson (3):
> Remove UART and KMI entries from DTS file
> Prototype of AMBA bus 'connector resource' for ACPI
> Hack clock names to get prototype running
>
> arch/arm64/boot/dts/foundation-v8-acpi.dts | 10 +-
> arch/arm64/boot/dts/rtsm_ve-aemv8a-acpi.dts | 4 +
> arch/arm64/boot/dts/rtsm_ve-motherboard-acpi.dtsi | 4 +
> drivers/acpi/acpi_platform.c | 2 +
> drivers/amba/Makefile | 2 +-
> drivers/amba/acpi.c | 172 +++++++++++++++++++++
> drivers/clk/clk-fixed-rate.c | 15 +-
> 7 files changed, 203 insertions(+), 6 deletions(-)
> create mode 100644 drivers/amba/acpi.c
>
> --
> 1.7.9.5
>
>
> ---
>
> Device (AMBA) {
> Name (_HID, "AMBA0000") /* the parallel to "arm,primecell" in DTS */
> Name (_UID, 0)
>
> /* Define 'apb_pclk' as a default clock source since it is
> common with devices below */
> Method(_DSM, 4, NotSerialized) {
> Store (Package (3)
> {
> "clock-name", "apb_pclk", "\\_SB_.CLK0",
> }, Local0)
>
> Return (Local0)
> }
>
> Device (KMI0) {
> Name (_ADR,0x1c060000)
> Method (_CRS, 0x0, Serialized) {
> Name (RBUF, ResourceTemplate () {
> Memory32Fixed (ReadWrite, 0x1c060000, 0x00010000)
> Interrupt (ResourceConsumer, Edge, ActiveBoth,
> Exclusive, , , ) {44}
> })
> Return (RBUF)
> }
> }
>
> Device (KMI1) {
> Name (_ADR,0x1c070000)
> Method (_CRS, 0x0, Serialized) {
> Name (RBUF, ResourceTemplate () {
> Memory32Fixed (ReadWrite, 0x1c070000, 0x00010000)
> Interrupt (ResourceConsumer, Edge, ActiveBoth,
> Exclusive, , , ) {45}
> })
> Return (RBUF)
> }
> }
>
> Device (SER0) {
> Name (_ADR,0x1c090000) // UART0
> Method (_CRS, 0x0, Serialized) {
> Name (RBUF, ResourceTemplate () {
> Memory32Fixed (ReadWrite, 0x1c090000, 0x00010000)
> Interrupt (ResourceConsumer, Edge, ActiveBoth,
> Exclusive, , , ) {37}
> })
> Return (RBUF)
> }
> }
>
> Device (SER1) {
> Name (_ADR,0x1c0a0000) // UART1
> Method (_CRS, 0x0, Serialized) {
> Name (RBUF, ResourceTemplate () {
> Memory32Fixed (ReadWrite, 0x1c0a0000, 0x00010000)
> Interrupt (ResourceConsumer, Edge, ActiveBoth,
> Exclusive, , , ) {38}
> })
> Return (RBUF)
> }
> }
> Device (SER2) {
> Name (_ADR,0x1c0b0000) // UART2
> Method (_CRS, 0x0, Serialized) {
> Name (RBUF, ResourceTemplate () {
> Memory32Fixed (ReadWrite, 0x1c0b0000, 0x00010000)
> Interrupt (ResourceConsumer, Edge, ActiveBoth,
> Exclusive, , , ) {39}
> })
> Return (RBUF)
> }
> }
>
> Device (SER3) {
> Name (_ADR,0x1c0c0000) // UART3
> Method (_CRS, 0x0, Serialized) {
> Name (RBUF, ResourceTemplate () {
> Memory32Fixed (ReadWrite, 0x1c0c0000, 0x00010000)
> Interrupt (ResourceConsumer, Edge, ActiveBoth,
> Exclusive, , , ) {40}
> })
> Return (RBUF)
> }
> }
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-22 8:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 0:33 [RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource brandon.anderson
2013-10-22 0:33 ` [RFC PATCH 1/3] ACPI: Remove UART and KMI entries from DTS file brandon.anderson
2013-10-23 11:28 ` Hanjun Guo
2013-10-22 0:33 ` [RFC PATCH 2/3] ACPI: Prototype of AMBA bus 'connector resource' brandon.anderson
2013-10-23 11:52 ` Hanjun Guo
2013-10-23 12:49 ` Graeme Gregory
2013-10-23 15:32 ` Anderson, Brandon
2013-10-22 0:33 ` [RFC PATCH 3/3] ACPI: Hack clock names to get prototype running brandon.anderson
2013-10-22 8:20 ` Naresh Bhat [this message]
2013-10-22 8:41 ` [RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource Graeme Gregory
2013-10-22 9:19 ` Naresh Bhat
2013-10-22 8:42 ` Graeme Gregory
2013-10-23 0:13 ` Anderson, Brandon
2013-10-23 7:37 ` Hanjun Guo
2013-10-23 15:44 ` Anderson, Brandon
2013-10-23 9:44 ` Naresh Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFoFrHY0vR5T0rX80UHQWcuAUPQdshz3TrQ5Eh3F7utrV9Yutg@mail.gmail.com \
--to=naresh.bhat@linaro.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=brandon.anderson@amd.com \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).