From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCEE81ADC98 for ; Wed, 12 Mar 2025 03:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741750205; cv=none; b=WQObBBUlgChV8AmzBOrY+GXyFKwRPK8yBpMz2WxiS4WHSxDiMbOcLLQuDhlyFwWldRsg94kyQcUkc25i7qRlGqsl7ebwJeKo/S0Lg73ulpCNIeXd4xERgSUMYdlGpyGMzHAl8NMwG1JCrC4bnMooZ+n4hrsbvyg+FeoSS4I31wM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741750205; c=relaxed/simple; bh=8lKtlD878CpQP9xdYqFaFtx3UJlB12BxxXmMp7FSGqs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ZYclgDj+cewShO4L9tGWcSNvQT4hPBm0xn9Rq1M3bDH8aV4aYHdK/6GXBEHm/kMfiynlEA0ygoWNJGSEqk6AnQGsFRJC0z2MvkMwHXm+R/ZuN2fwT8QWmAcicWJkI0f3734LBw96NuplRGK0xoGZYQwwryGXhU1GU4D5BF/A2c8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SCdnctzN; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SCdnctzN" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-549a2997973so2823e87.1 for ; Tue, 11 Mar 2025 20:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741750202; x=1742355002; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RTC6q0jJyCwm0Ms6LHn8x6WPWhr3FL+RLBtkQPmtIBA=; b=SCdnctzNnSQ6OV94jeyRzz30MMnwKbd/5DR3O/n9/ZAEWRmHwSq23ZieiscVfXd2k3 XfDPJcXyI2Uh8RWOWMcINcUSEi3w8miJif/NMwqoe0UtaeFSnZGhiQ354mOz47F0p31l W/QEpUcu2lHpBvpzhHyADnj9J6nnw1xqCBquRj064VT3P57hjd3UZmuXiDkXsbpwD7WY RUn73/+1gs0JdvtLneFsbO9XZ0+m1/oufcO8FxdUIRlgsi7kVvX0rPj31/zpSqbZc961 VGFQdIm0flEBAuAqgblCOp6SXqv1qj5NrFd7mdUO61wO01BqhrPl1mCk/6501yb6wtHB sorA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741750202; x=1742355002; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RTC6q0jJyCwm0Ms6LHn8x6WPWhr3FL+RLBtkQPmtIBA=; b=cmikKi9coeAE/GP1LM/wjjvSGLDUzWlY1eQrV+IsQXRntJpsksuv5mTBW/G2XJoGyM 3Mxk5oaqT5a6Fvq7GhI8B0bUZmanpJ9SZ2LX0ryFcmWKidxHlUOtizEky2SiHaue04oB fkq97OqayKkaRABTWMyTzhNTF7o1X/3VYAEVNfQJq3LTH+RQ02P6yyfjLYJBDQ3qwQ51 PjEBqUe1RkDLogIsPmbnDywssGi/fxWHHEZV/p1fOSVWEXrn55lNKV3dj0B+Bck881aL dT9EGycKeZjkL4oC7wnnSz2tJEWjmmgXG1DhSIt/d5FEofxaWxhAOma1AxJrYJxMVSx8 rd/g== X-Forwarded-Encrypted: i=1; AJvYcCWAIbF4JEPFNtOsxT/R2L+uVNBZXRISl7bX7SEs0qbw1NJZuLm+MC8UbfM9DNS9HW9yIG5n9kQSDPLQ@vger.kernel.org X-Gm-Message-State: AOJu0Ywizv+gSOv5iVB0byr0dXTB4W79Vmc8qu8ajE8A9vzVrLlMJNEd udGk7yGeOhRJ0Ja8WBH7ZNXkVr0EH+eSK6p6WmghZQ2LB8KjCCajFIMiRsXuJslwof48M/slenC 0O2TQYg6KqkvpV5xwKvGlTWemeL8yBfDxv6r7 X-Gm-Gg: ASbGncsZ2scgENsbbihlbDnteKxWstqp8QDPhSjBhcOGPcmCqIEVlNXkIBowwuXn/aF BFia6gzftEzPt48zk0ZH6Hk7pEkn07wohLFa5qa7dO/2Xa7MkkmGcfiWjCYtuYIE8PyupubuUYT XqJduJ6o/CG0LHmLW64aW9iZSr0JgsKEZE6fHx1NS1cA6MSv6Uv8r0spX9 X-Google-Smtp-Source: AGHT+IGP1YVSO5G5A7NPOF9hu8UMZmUxtP+Fj7fvYTNYvV5zNSe928DhT3IQzPqsLEwOPja96dJF23KWfgwjHorjZPM= X-Received: by 2002:a05:6512:3c96:b0:545:1dea:7b2e with SMTP id 2adb3069b0e04-549b1c370camr195846e87.6.1741750201654; Tue, 11 Mar 2025 20:30:01 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250310150835.3139322-1-andriy.shevchenko@linux.intel.com> <20250310150835.3139322-5-andriy.shevchenko@linux.intel.com> In-Reply-To: <20250310150835.3139322-5-andriy.shevchenko@linux.intel.com> From: Kyle Tso Date: Wed, 12 Mar 2025 11:29:45 +0800 X-Gm-Features: AQ5f1JqezutAuLR9RCiDwHugv6YDAlJdEYt9fLJCmtrMads3aQIZSAKhgQtQ5Ys Message-ID: Subject: Re: [PATCH v1 4/4] usb: typec: tcpm: Use fwnode_get_child_node_count() To: Andy Shevchenko Cc: Greg Kroah-Hartman , "Rob Herring (Arm)" , Markus Elfring , Jakob Riepler , Heikki Krogerus , Jonathan Cameron , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-usb@vger.kernel.org, Daniel Scally , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Lee Jones , Pavel Machek , Matti Vaittinen , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 10, 2025 at 11:09=E2=80=AFPM Andy Shevchenko wrote: > > Since fwnode_get_child_node_count() was split from its device property > counterpart, we may utilise it in the driver and drop custom implementati= on. > > Signed-off-by: Andy Shevchenko Acked-by: Kyle Tso > --- > drivers/usb/typec/tcpm/tcpm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.= c > index 9c455f073233..8ca2e26752fb 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -7166,7 +7166,7 @@ static void tcpm_fw_get_timings(struct tcpm_port *p= ort, struct fwnode_handle *fw > > static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle= *fwnode) > { > - struct fwnode_handle *capabilities, *child, *caps =3D NULL; > + struct fwnode_handle *capabilities, *caps =3D NULL; > unsigned int nr_src_pdo, nr_snk_pdo; > const char *opmode_str; > u32 *src_pdo, *snk_pdo; > @@ -7232,9 +7232,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,= struct fwnode_handle *fwnode > if (!capabilities) { > port->pd_count =3D 1; > } else { > - fwnode_for_each_child_node(capabilities, child) > - port->pd_count++; > - > + port->pd_count =3D fwnode_get_child_node_count(capabiliti= es); > if (!port->pd_count) { > ret =3D -ENODATA; > goto put_capabilities; > -- > 2.47.2 > >