From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-acpi@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, mjg@redhat.com, rjw@sisk.pl,
len.brown@intel.com, dtor@insightbb.com
Subject: Re: [PATCH 3/3] thinkpad_acpi: Wire unused micmute LED to capslock
Date: Thu, 22 Aug 2013 19:29:56 +0200 [thread overview]
Message-ID: <CAHmME9rHX=3UrFEERkGs0AvGuvoSJYKz35qsMaith4zSDzQTxg@mail.gmail.com> (raw)
In-Reply-To: <20130822153900.GA2878@srcf.ucam.org>
On Thu, Aug 22, 2013 at 5:39 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> I think there's a risk of user confusion here, in that it's now possible
> for the mic mute light to be lit despite the internal microphone still
> being active. That seems like surprising behaviour.
Yeah, that is a legitimate concern. Patches 1/3 [1] and 2/3 [2]
clearly make sense, as they're generic and don't really suggest any
new behavior.
But setting this behavior here as the default could indeed be a bit
unexpected. I think it's fair to reject this patch (3/3), but accept
the first two. Tweakers who have the same early boot caps-lock LED
needs as me can simply put this in their initramfs after 1/3 and 2/3
are applied:
# echo caps-lock >
/sys/devices/platform/thinkpad_acpi/leds/tpacpi\:\:micmute/trigger
Jason
[1] https://lkml.org/lkml/2013/8/22/310
[2] https://lkml.org/lkml/2013/8/22/313
next prev parent reply other threads:[~2013-08-22 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 14:02 [PATCH 1/3] Input: atkbd - add LED triggers for keyboard state Jason A. Donenfeld
2013-08-22 14:02 ` [PATCH 2/3] thinkpad_acpi: Support micmute LED Jason A. Donenfeld
2013-08-23 18:16 ` Henrique de Moraes Holschuh
2013-08-22 14:02 ` [PATCH 3/3] thinkpad_acpi: Wire unused micmute LED to capslock Jason A. Donenfeld
2013-08-22 15:39 ` Matthew Garrett
2013-08-22 17:29 ` Jason A. Donenfeld [this message]
2013-08-23 18:18 ` Henrique de Moraes Holschuh
2013-08-24 20:29 ` Jason A. Donenfeld
2013-09-22 14:26 ` [PATCH 1/3] Input: atkbd - add LED triggers for keyboard state Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9rHX=3UrFEERkGs0AvGuvoSJYKz35qsMaith4zSDzQTxg@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=dtor@insightbb.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).