From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v6 20/22] driver core: Allow deferring probes until late init Date: Tue, 29 Sep 2015 11:58:47 -0500 Message-ID: References: <1442844182-27787-1-git-send-email-tomeu.vizoso@collabora.com> <1442844182-27787-21-git-send-email-tomeu.vizoso@collabora.com> <5606E0DA.2040900@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-yk0-f169.google.com ([209.85.160.169]:34223 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753943AbbI2Q7K (ORCPT ); Tue, 29 Sep 2015 12:59:10 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Tomeu Vizoso Cc: "linux-kernel@vger.kernel.org" , Stephen Warren , Javier Martinez Canillas , Greg Kroah-Hartman , Mark Brown , Thierry Reding , Alan Stern , "Rafael J. Wysocki" , "linux-arm-kernel@lists.infradead.org" , Dmitry Torokhov , "devicetree@vger.kernel.org" , Linus Walleij , "linux-acpi@vger.kernel.org" , Arnd Bergmann On Tue, Sep 29, 2015 at 3:05 AM, Tomeu Vizoso wrote: > On 26 September 2015 at 20:15, Rob Herring wrote: >> On 09/21/2015 09:03 AM, Tomeu Vizoso wrote: >>> Add a field to struct device that instructs the device-driver core to >>> defer the probe of this device until the late_initcall level. >> >> This is true until the next patch with moves deferred probe processing >> to device_initcall_sync. So disabling this option alone won't totally >> revert to current behaviour. I guess patch 21 could be reverted if >> necessary. > > Actually, the goal with that commit was to prevent potential problems > due to the increased pressure on late_initcall, as suggested by > Grygorii Strashko, but I haven't found yet any evidence of it being > needed, and in my testing the series boot all boards in kernelci with > or without this commit. So I would just not commit it for now and only > consider applying it later if someone reports a problem. I had similar concerns with assumptions about ordering WRT late_initcall. I would keep this for now. Rob