From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org,
Matthew Garrett <matthew.garrett@nebula.com>,
seth.forshee@canonical.com, joeyli.kernel@gmail.com,
daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
lenb@kernel.org, Aaron Lu <aaron.lu@intel.com>,
Igor Gnatenko <i.gnatenko.brain@gmail.com>,
Yves-Alexis Perez <corsac@debian.org>,
"Lee, Chun-Yi" <jlee@suse.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Subject: Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems
Date: Sat, 20 Jul 2013 08:16:56 -0500 [thread overview]
Message-ID: <CAMP44s2fT8C=wfF-uadxTOSzqLLfjFTJMQ767qy6teJZh_SS6w@mail.gmail.com> (raw)
In-Reply-To: <1448863.3slS729B6b@vostro.rjw.lan>
On Wed, Jul 17, 2013 at 7:16 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote:
>> Windows 8 introduced new policy for backlight control by pushing it out to
>> graphics drivers. This appears to have coincided with a range of vendors
>> adding Windows 8 checks to their backlight control code which trigger either
>> awkward behaviour (Lenovo) or complete brokenness (some Dells). The simplest
>> thing to do would be to just disable ACPI backlight control entirely if the
>> firmware indicates Windows 8 support, but it's entirely possible that
>> individual graphics drivers might still make use of the ACPI functionality in
>> preference to native control.
>>
>> The first two patches in this series are picked from other patchesets aimed at
>> solving similar problems. The last simply unregisters ACPI backlight control
>> on Windows 8 systems when using an Intel GPU. Similar code could be added to
>> other drivers, but I'm reluctant to do so without further investigation as
>> to the behaviour of the vendor drivers under Windows.
>
> Well, after some more time spent on that, we now have a series of 3 patches
> (different from the $subject one) that we think may be used to address this
> issue. As far as I can say, it has been tested by multiple people whose
> systems have those problems and they generally saw improvement.
>
> It is not my ideal approach, but it seems to be the least intrusive and/or
> with the least amount of possible side effects that we can do right now
> as a general measure (alternatively, we could create a possibly long
> blacklist table of affected systems with different workarounds for them,
> but let's just say that is not overwhelmingly attractive).
>
> [1/3] Make ACPICA export things that we need for checking OSI(Win8).
>
> [2/3] Make acpi_video_device_find_cap() call acpi_video_init_brightness() even
> if it is not going to register the backlight interface (needed for
> Thinkpads).
>
> [3/3] Avoid using ACPI backlight if i915 is in use and the firmware believes
> we are Windows 8.
>
> Many thanks to everyone involved!
I tried this patch series and it's as I expected, it's the same as
acpi_backlight=vendor, and the intel backlight driver doesn't work
correctly in this machine. If you are actually serious about the
mantra of "no user-space regressions", then for this machine at least,
you need to use the ACPI backlight with Windows8 OSI disabled, until
the intel backlight driver is fixed. My patch does that:
http://article.gmane.org/gmane.linux.acpi.devel/60969
--
Felipe Contreras
next prev parent reply other threads:[~2013-07-20 13:16 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 23:01 [PATCH 0/3] Fix backlight issues on some Windows 8 systems Matthew Garrett
2013-06-09 23:01 ` [PATCH 1/3] acpi: video: add function to support unregister backlight interface Matthew Garrett
2013-06-09 23:01 ` [PATCH 2/3] ACPICA: Add interface for getting latest OS version requested via _OSI Matthew Garrett
2013-06-17 22:31 ` Rafael J. Wysocki
2013-06-17 22:37 ` Matthew Garrett
2013-06-18 0:42 ` Rafael J. Wysocki
2013-06-25 23:23 ` Rafael J. Wysocki
2013-07-02 13:56 ` [PATCH 0/2] Expose OSI version Aaron Lu
2013-07-02 13:59 ` [PATCH 1/2] ACPICA: expose " Aaron Lu
2013-07-02 14:01 ` [PATCH 2/2] ACPI / OSL: add a wrapper function to return " Aaron Lu
2013-07-03 21:57 ` Rafael J. Wysocki
2013-07-04 1:24 ` Aaron Lu
2013-07-05 19:52 ` Rafael J. Wysocki
2013-06-09 23:01 ` [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8 Matthew Garrett
2013-06-10 7:40 ` Daniel Vetter
2013-06-10 9:22 ` joeyli
2013-06-10 14:09 ` Alex Deucher
2013-06-14 6:47 ` Aaron Lu
2013-06-14 17:29 ` Matthew Garrett
2013-06-15 1:26 ` Aaron Lu
2013-06-15 1:38 ` Matthew Garrett
2013-06-15 4:14 ` Aaron Lu
2013-06-15 4:19 ` Matthew Garrett
2013-06-15 12:29 ` Aaron Lu
2013-06-15 15:16 ` Matthew Garrett
2013-06-15 18:29 ` Daniel Vetter
2013-06-15 18:44 ` Matthew Garrett
2013-06-15 20:27 ` Rafael J. Wysocki
2013-06-15 20:35 ` Daniel Vetter
2013-07-05 12:20 ` Rafael J. Wysocki
2013-07-05 20:00 ` Rafael J. Wysocki
2013-07-05 21:40 ` Rafael J. Wysocki
2013-07-05 22:23 ` Rafael J. Wysocki
2013-07-06 5:45 ` Aaron Lu
2013-07-06 13:33 ` Rafael J. Wysocki
2013-07-07 13:19 ` Rafael J. Wysocki
2013-07-08 8:00 ` Aaron Lu
2013-07-13 0:46 ` [Update][PATCH] ACPI / video / i915: Remove ACPI backlight " Rafael J. Wysocki
2013-07-15 2:36 ` Aaron Lu
2013-07-15 11:42 ` Rafael J. Wysocki
2013-07-16 3:24 ` Aaron Lu
2013-07-16 11:54 ` Rafael J. Wysocki
2013-07-15 13:06 ` Igor Gnatenko
2013-07-15 23:53 ` Rafael J. Wysocki
2013-07-16 7:45 ` Igor Gnatenko
2013-07-16 13:32 ` Igor Gnatenko
2013-07-16 17:08 ` Matthew Garrett
2013-07-16 22:01 ` Rafael J. Wysocki
2013-07-17 5:16 ` Igor Gnatenko
2013-07-17 11:38 ` Rafael J. Wysocki
2013-07-17 12:03 ` Igor Gnatenko
2013-06-10 11:59 ` [PATCH 0/3] Fix backlight issues on some Windows 8 systems Rafael J. Wysocki
2013-06-10 13:48 ` Matthew Garrett
2013-06-11 13:08 ` Seth Forshee
2013-06-22 21:46 ` Yves-Alexis Perez
2013-06-25 16:08 ` Matthew Garrett
2013-06-25 16:10 ` Daniel Vetter
2013-06-25 16:13 ` Matthew Garrett
2013-06-25 20:43 ` Yves-Alexis Perez
2013-06-25 20:54 ` Matthew Garrett
2013-06-25 21:10 ` Yves-Alexis Perez
2013-06-25 21:14 ` Matthew Garrett
2013-06-25 21:30 ` Yves-Alexis Perez
2013-06-25 21:33 ` Matthew Garrett
2013-06-25 21:46 ` Yves-Alexis Perez
2013-06-25 21:49 ` Matthew Garrett
2013-07-17 15:51 ` Felipe Contreras
2013-07-17 19:57 ` Yves-Alexis Perez
2013-07-18 0:16 ` [Update][PATCH " Rafael J. Wysocki
2013-07-18 0:20 ` [PATCH 1/3] ACPICA: expose OSI version Rafael J. Wysocki
2013-07-18 5:38 ` Igor Gnatenko
2013-07-18 0:21 ` [PATCH 2/3] ACPI / video: Always call acpi_video_init_brightness() on init Rafael J. Wysocki
2013-07-18 5:40 ` Igor Gnatenko
2013-07-18 0:22 ` [PATCH 3/3] ACPI / video / i915: No ACPI backlight if firmware expects Windows 8 Rafael J. Wysocki
2013-07-20 13:16 ` Felipe Contreras [this message]
2013-07-31 0:01 ` [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems Rafael J. Wysocki
2013-07-31 0:01 ` Matthew Garrett
2013-07-31 6:48 ` Igor Gnatenko
2013-07-31 9:08 ` Aaron Lu
2013-08-07 7:44 ` Backlight control only in the kernel? Borislav Petkov
2013-08-07 9:03 ` Aaron Lu
2013-08-07 10:34 ` Borislav Petkov
2013-08-07 10:36 ` Matthew Garrett
2013-08-07 11:04 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s2fT8C=wfF-uadxTOSzqLLfjFTJMQ767qy6teJZh_SS6w@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=aaron.lu@intel.com \
--cc=corsac@debian.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hmh@hmh.eng.br \
--cc=i.gnatenko.brain@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rjw@sisk.pl \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).