From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA5FC433E2 for ; Mon, 7 Sep 2020 13:50:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC1672078E for ; Mon, 7 Sep 2020 13:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="0bzBc0rj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729649AbgIGNt5 (ORCPT ); Mon, 7 Sep 2020 09:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729635AbgIGNto (ORCPT ); Mon, 7 Sep 2020 09:49:44 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB6FC061756 for ; Mon, 7 Sep 2020 06:49:36 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id b12so12846640edz.11 for ; Mon, 07 Sep 2020 06:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XZkLomLib6REZxGcB13cjfAcIZQ8j5/AgQHdwRkSrk0=; b=0bzBc0rjsSCxBE1AN+yH+086oSRWcCd5qjvDJyEnbLsLlSfTn9H3CvFC3r7VPMXKWs Eh8DEj/bnaCcJgdGu5U9TG0LTuxYm5RXKgbSkJex+auJVF5Col6AkxfTfbL8pdj2fM2T 7iH+Z7OcAy2lOMZlUhM5cM2B2GCZG9aeyKCmvopGO5D7iz/IhUd+V5YKZ/y9huDb9aAs xzGPurWWxhiEbCZBUxLDJe6+dZFG9jUwWta6P1dli45fq+JfthHFj/6Jy/VREBX13VqK KgcPw0LJ97bBwsm6h3Pt2hObpI8UuQhLBnUwbfMVYJ0mxdKcT2lUGNIIX3HLofO5SsE4 bicQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XZkLomLib6REZxGcB13cjfAcIZQ8j5/AgQHdwRkSrk0=; b=C5623kV5ixDp9WbGld2m00apCl5ux1iAy6/IpNSvvkRQTuQYA3+xYMDnbDBd/9fXWR WElO0afLWjo9ti/lFF/y2vmLdk+xBZvZwYgWTL5nn7l0vplzAzMhTsobstcTKa/ceHLD OzLg03VrnIEnxFrZ0Dza3bGtD/N6bLJmZLAV56L+qgRbAu/YnKz1thMr0FtOabXq7YBX rKTe2ybtZxv9VYpFV1v6Di13toN/s5nP0upXeoyxpI4ENrqYWeNhzcboT9Cr6t9FowPG xjk8PVeRYh2itRBAw4dElsqaTIdrt26KDq/T/Tll5Q9QILYUpIdYoj8X2sFbk3UDsWqx hu0Q== X-Gm-Message-State: AOAM532L9wAKIXTFzMflOHcGoU8d1808BVKcRSc3X1Uf6iibBe1Zu51P p93trFx+PCdAOoT9W+Lt75egS2fCETjrXoarohFhZg== X-Google-Smtp-Source: ABdhPJzhEluKdgYZ4MWnxjBqFsobQ3ZUoS/aewy6S0+xnMJ7yFw4veFRt3xmMQoMX1dmxmwU0YOjWmerxNVEkmWgDqM= X-Received: by 2002:a05:6402:b72:: with SMTP id cb18mr21084458edb.299.1599486574313; Mon, 07 Sep 2020 06:49:34 -0700 (PDT) MIME-Version: 1.0 References: <20200904154547.3836-1-brgl@bgdev.pl> <20200904154547.3836-24-brgl@bgdev.pl> <26ea1683-da8f-30e7-f004-3616e96d56b3@infradead.org> <20200907095932.GU1891694@smile.fi.intel.com> <20200907115310.GA1891694@smile.fi.intel.com> <20200907122238.GA1849893@kroah.com> In-Reply-To: <20200907122238.GA1849893@kroah.com> From: Bartosz Golaszewski Date: Mon, 7 Sep 2020 15:49:23 +0200 Message-ID: Subject: Re: [PATCH 23/23] Documentation: gpio: add documentation for gpio-mockup To: Greg Kroah-Hartman , Andy Shevchenko , Linus Walleij , Kent Gibson Cc: Randy Dunlap , Bartosz Golaszewski , Jonathan Corbet , Mika Westerberg , linux-gpio , linux-doc , LKML , ACPI Devel Maling List Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Sep 7, 2020 at 2:22 PM Greg Kroah-Hartman wrote: > > On Mon, Sep 07, 2020 at 02:06:15PM +0200, Bartosz Golaszewski wrote: > > On Mon, Sep 7, 2020 at 1:53 PM Andy Shevchenko > > wrote: > > > > > > On Mon, Sep 07, 2020 at 12:26:34PM +0200, Bartosz Golaszewski wrote: > > > > On Mon, Sep 7, 2020 at 11:59 AM Andy Shevchenko > > > > wrote: > > > > > > > > > > On Fri, Sep 04, 2020 at 08:15:59PM -0700, Randy Dunlap wrote: > > > > > > On 9/4/20 8:45 AM, Bartosz Golaszewski wrote: > > > > > > > > > > ... > > > > > > > > > > > > +GPIO Testing Driver > > > > > > > +=================== > > > > > > > + > > > > > > > +The GPIO Testing Driver (gpio-mockup) provides a way to create simulated GPIO > > > > > > > +chips for testing purposes. There are two ways of configuring the chips exposed > > > > > > > +by the module. The lines can be accessed using the standard GPIO character > > > > > > > +device interface as well as manipulated using the dedicated debugfs directory > > > > > > > +structure. > > > > > > > > > > > > Could configfs be used for this instead of debugfs? > > > > > > debugfs is ad hoc. > > > > > > > > > > Actually sounds like a good idea. > > > > > > > > > > > > > Well, then we can go on and write an entirely new mockup driver > > > > (ditching module params and dropping any backwards compatibility) > > > > because we're already using debugfs for line values. > > > > > > > > How would we pass the device properties to configfs created GPIO chips > > > > anyway? Devices seem to only be created using mkdir. Am I missing > > > > something? > > > > > > Same way how USB composite works, no? > > > > > > > OK, so create a new chip directory in configfs, configure it using > > some defined configfs attributes and then finally instantiate it from > > sysfs? > > > > Makes sense and is probably the right way to go. Now the question is: > > is it fine to just entirely remove the previous gpio-mockup? Should we > > keep some backwards compatibility? Should we introduce an entirely new > > module and have a transition period before removing previous > > gpio-mockup? > > > > Also: this is a testing module so to me debugfs is just fine. Is > > configfs considered stable ABI like sysfs? > > Yes it is. Or at least until you fix all existing users so that if you > do change it, no one notices it happening :) > Then another question is: do we really want to commit to a stable ABI for a module we only use for testing purposes and which doesn't interact with any real hardware. Rewriting this module without any legacy cruft is tempting though. :) Bart