Linux ACPI
 help / color / mirror / Atom feed
From: "Sajjan, Vikas C" <vikas.cha.sajjan@hpe.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Seunghun Han <kkamagui@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	"Lakshminarasimha, Sunil Vishwanathpur" <sunil.vl@hpe.com>,
	"Attar, Abdul Lateef" <abdul-lateef.attar@hpe.com>
Subject: RE: [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode
Date: Wed, 15 Nov 2017 17:30:46 +0000	[thread overview]
Message-ID: <CS1PR8401MB05189C5186CD6E4B6509EAD5D9290@CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAJZ5v0g8d=q1TZvacBZ_EDMjAnufQdHYkfbnkhv4kSH_FNOhDg@mail.gmail.com>

Hi Rafael,

-----Original Message-----
From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. Wysocki
Sent: Wednesday, November 15, 2017 10:51 PM
To: Sajjan, Vikas C <vikas.cha.sajjan@hpe.com>
Cc: Linux PM <linux-pm@vger.kernel.org>; ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Rafael J. Wysocki <rjw@rjwysocki.net>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Seunghun Han <kkamagui@gmail.com>; Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@kernel.org>; Lakshminarasimha, Sunil Vishwanathpur <sunil.vl@hpe.com>; Attar, Abdul Lateef <abdul-lateef.attar@hpe.com>
Subject: Re: [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode

On Fri, Nov 10, 2017 at 10:38 AM, Vikas C Sajjan <vikas.cha.sajjan@hpe.com> wrote:
> The platforms which support only IOAPIC mode and whose SCI INT is 
> greater than 16, passes SCI INT via FADT and not via MADT int src 
> override structure. In such cases current logic fails to handle it and 
> throws error "Invalid bus_irq %u for legacy override". This patch 
> handles the above  mentioned case. While at it, also modify function 
> mp_override_legacy_irq() to use the newly introduced function mp_register_ioapic_irq().

Actually, is it necessary to make this extra change here?

How complicated would it be to separate it out?

I can move these extra changes into a separate patch and keep only the fix in this patch.

Thanks,
Rafael

Thanks,
Vikas Sajjan

  reply	other threads:[~2017-11-15 17:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10  9:38 [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode Vikas C Sajjan
2017-11-15 10:05 ` Sajjan, Vikas C
2017-11-15 17:18   ` Rafael J. Wysocki
2017-11-15 17:20 ` Rafael J. Wysocki
2017-11-15 17:30   ` Sajjan, Vikas C [this message]
2017-11-15 17:58     ` Rafael J. Wysocki
2017-11-15 18:30       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB05189C5186CD6E4B6509EAD5D9290@CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM \
    --to=vikas.cha.sajjan@hpe.com \
    --cc=abdul-lateef.attar@hpe.com \
    --cc=kkamagui@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sunil.vl@hpe.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox