Re: [V4 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching

["Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>]

On 3/2/15, 10:41, "Tejun Heo" <tj@kernel.org> wrote:

>On Mon, Mar 02, 2015 at 02:27:20AM -0600, Suravee Suthikulpanit wrote:
>> This patch adds ACPI supports for AHCI platform driver, which uses _CLS
>> method to match the device.
>> 
>> The following is an example of ASL structure in DSDT for a SATA
>>controller,
>> which contains _CLS package to be matched by the ahci_platform driver:
>> 
>>   Device (AHC0) // AHCI Controller
>>   {
>>     Name(_HID, "AMDI0600")
>>     Name (_CCA, 1)
>>     Name (_CLS, Package (3)
>>     {
>>       0x01, // Base Class: Mass Storage
>>       0x06, // Sub-Class: serial ATA
>>       0x01, // Interface: AHCI
>>     })
>>     Name (_CRS, ResourceTemplate ()
>>     {
>>       Memory32Fixed (ReadWrite, 0xE0300000, 0x00010000)
>>       Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive,,,) {
>>387 }
>>     })
>>   }
>> 
>> Also, since ATA driver should not require PCI support for ATA_ACPI,
>> this patch removes dependency in the driver/ata/Kconfig.
>> 
>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>
>Looks good to me from the libata side.
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
>Please let me now if this needs to go through libata.
>
>Thanks.
>
>-- 
>tejun

Thank you. I will let you know one the whole series is ready.

Suravee