From: "Kurt Borja" <kuurtb@gmail.com>
To: "Armin Wolf" <W_Armin@gmx.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>
Cc: "Mario Limonciello" <mario.limonciello@amd.com>,
"Len Brown" <lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI: platform_profile: Optimize _aggregate_choices()
Date: Tue, 25 Mar 2025 17:06:58 -0300 [thread overview]
Message-ID: <D8PM9ESWNN10.QARF2AMDMH6W@gmail.com> (raw)
In-Reply-To: <a66f55aa-9ee1-404b-8f78-258b307ea361@gmx.de>
On Tue Mar 25, 2025 at 4:36 PM -03, Armin Wolf wrote:
> Am 22.03.25 um 22:03 schrieb Kurt Borja:
>
>> Choices aggregates passed to _aggregate_choices() are already filled
>> with ones, therefore we can avoid copying a new bitmap on the first
>> iteration.
>>
>> This makes setting the PLATFORM_PROFILE_LAST bit on aggregates
>> unnecessary, so drop it as well.
>>
>> While at it, add a couple empty lines to improve style.
>>
> Please add a comment to signal future developers that the bitmap needs to be filled with ones
> before being passed to _aggregate_choices().
Sure, I'll mention it in the kernel-doc for v2.
>
> With this being addressed:
>
> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Thank you Mario and Armin for the reviews!
--
~ Kurt
prev parent reply other threads:[~2025-03-25 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 21:03 [PATCH] ACPI: platform_profile: Optimize _aggregate_choices() Kurt Borja
2025-03-24 14:25 ` Mario Limonciello
2025-03-25 19:36 ` Armin Wolf
2025-03-25 20:06 ` Kurt Borja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8PM9ESWNN10.QARF2AMDMH6W@gmail.com \
--to=kuurtb@gmail.com \
--cc=W_Armin@gmx.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox