From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F07E3379974; Tue, 24 Feb 2026 13:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771940858; cv=none; b=C3uROa9e1sTLBe08frO/P68Mhsr9MY6+qPRTmGT9DyMrdcynI1avXlaPpVeqF7/P8wLcIRguLSlZk/ppyfg56a5kmXTBeU7+P6tJFjq5KIxQ1YHxyeI+WS0UaikviBAhomBHlK1x5kHav7jA99ybL95UIuCtsvnympVDXbdVj08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771940858; c=relaxed/simple; bh=q2R5e1cZ/PwyeT+nSHUGIWZ7CSz8/wQnDWc+REwaRNQ=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=euk2YlxZYQ/sCCBIzOgq3a+G2mUUwZGEIrrFaEWFVVHE8Dgc/5wN5BBxBEw+BM0mEQHk4fdRgtzHXPDVmhdikC2VSgq6xC5JimUEL2fo+MnXHgPtffijaJQrPvSAPQxA3rM7ZuNT63fSc34MB0YaRPj6KHHtEI/qpl7LZmb/Lp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X7z7YoBn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X7z7YoBn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65593C116D0; Tue, 24 Feb 2026 13:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771940857; bh=q2R5e1cZ/PwyeT+nSHUGIWZ7CSz8/wQnDWc+REwaRNQ=; h=Date:To:From:Subject:Cc:References:In-Reply-To:From; b=X7z7YoBnkxdp/8wnlMOhKxDrb09SX+i6bxgqHT/EYyPIxkkIGYd2x1E1PH/pTcAW3 w/hhgus0zqqmgSwcyMqAnlA3CO8xbsNNIF7vfa+8+oPoKXGzlfsaGpQgXRGoxtokQc VGiu6LPY8fPYc5wfFXkHLWxYKFeCsG2wQHA9TBgZhfN28u0RQieGG/YTXUUqxCUpuW tOf9NdY7RmGiII2hhWrh3xbzcQA5Hng8lI82W0vHzP/YV7x3i1Im+LNfiehCOgCpQ9 iNXOLklwaMUW6hphgg40MEpY3h3AqCfgNtLpod3BkYrY/uepGGSL+1Sij4BVU9b7oz yQW6EkDwmkQVg== Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 24 Feb 2026 14:47:33 +0100 Message-Id: To: "Greg Kroah-Hartman" From: "Danilo Krummrich" Subject: Re: [PATCH v1 1/3] driver core: Split device data types to device/types.h Cc: "Rafael J. Wysocki" , "Andy Shevchenko" , "Zijun Hu" , , , , "Len Brown" , "Daniel Scally" , "Heikki Krogerus" , "Sakari Ailus" References: <20260223204412.3298508-1-andriy.shevchenko@linux.intel.com> <20260223204412.3298508-2-andriy.shevchenko@linux.intel.com> <2026022436-scrambled-mumbling-59a3@gregkh> In-Reply-To: <2026022436-scrambled-mumbling-59a3@gregkh> On Tue Feb 24, 2026 at 2:17 PM CET, Greg Kroah-Hartman wrote: > On Tue, Feb 24, 2026 at 01:21:10PM +0100, Rafael J. Wysocki wrote: >> On Tue, Feb 24, 2026 at 10:05=E2=80=AFAM Andy Shevchenko >> wrote: >> > >> > On Mon, Feb 23, 2026 at 09:53:17PM +0100, Rafael J. Wysocki wrote: >> > > On Mon, Feb 23, 2026 at 9:44=E2=80=AFPM Andy Shevchenko >> > > wrote: >> > > > >> > > > device.h is a huge header which is hard to follow and easy to miss >> > > > something. Improve that by splitting device data types to device/t= ypes.h. >> > > > >> > > > In particular this helps to speedup the build of the code that inc= ludes >> > > > device.h solely for a device data types. >> > > > >> > > > Signed-off-by: Andy Shevchenko >> > > >> > > But why do you want to move the struct device definition out of devi= ce.h? >> > >> > Because it's a data type, and we have many drivers that may require it >> > (embed the struct device), but no device.h API is called directly =E2= =80=94 >> > only via a certain framework). >> > >> > device.h also includes many unrelated headers in such a case. >>=20 >> Why is this a problem? >>=20 >> Could those headers be moved to different header files instead? >>=20 >> device.h is mostly about the struct device definition and the other >> stuff in it is more or less additional. Why do you want to make it >> the other way around? > > I agree, this feels wrong. To me device/types.h also seems superfluous, the other ones seem OK to me a= s they structure things a bit better.