From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH 9/9] drivers/acpi: correct error-handling code Date: Tue, 28 Jul 2009 17:56:35 +0200 (CEST) Message-ID: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mgw1.diku.dk ([130.225.96.91]:35764 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555AbZG1P4l (ORCPT ); Tue, 28 Jul 2009 11:56:41 -0400 Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: rui.zhang@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Julia Lawall backlight_device_register may return an ERR_PTR value rather than a valid pointer. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier fld,fld1; expression x,E; @@ x = backlight_device_register(...) ... when != x = E when != &x when != x->fld1 ( ((IS_ERR(x))||...) | * x->fld ) // Signed-off-by: Julia Lawall --- drivers/acpi/video.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 8851315..29788db 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -982,6 +982,8 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device) sprintf(name, "acpi_video%d", count++); device->backlight = backlight_device_register(name, NULL, device, &acpi_backlight_ops); + if (IS_ERR(device->backlight)) + return; device->backlight->props.max_brightness = device->brightness->count-3; kfree(name);