Re: [PATCH v9 01/10] iommu: Remove obsolete comment

Jean-Philippe Brucker
2021-01-20T17:49:41Z

On Tue, Jan 19, 2021 at 11:11:44AM +0000, Jonathan Cameron wrote:
> On Fri, 8 Jan 2021 15:52:09 +0100
> Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
>
> > Commit 986d5ecc5699 ("iommu: Move fwspec->iommu_priv to struct
> > dev_iommu") removed iommu_priv from fwspec. Update the struct doc.
> >
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org
>
> Hi Jean-Philippe,
>
> Flags parameter doesn't have any docs in this structure and should
> do given kernel-doc should be complete. It probably spits out a warning
> for this if you build with W=1

Ah right, I had a patch removing the flags field locally, but I'm not
planning to upstream that one anymore. I don't mind fixing up the comment
in next version.

Thanks,
Jean

>
> Not sure if it makes sense to fix that in this same patch, or as a different
> one as the responsible patch is a different one.
> Looks like that came in:
> Commit 5702ee24182f ("ACPI/IORT: Check ATS capability in root complex nodes")
>
> Also, good to get this patch merged asap so we cut down on the noise in the
> interesting part of this series!
>
> FWIW
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Jonathan