From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF53C433DB for ; Tue, 29 Dec 2020 00:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15DCF207CF for ; Tue, 29 Dec 2020 00:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728284AbgL2AH6 (ORCPT ); Mon, 28 Dec 2020 19:07:58 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:44820 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbgL2AH6 (ORCPT ); Mon, 28 Dec 2020 19:07:58 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BC5D98; Tue, 29 Dec 2020 01:07:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1609200434; bh=d4Mhfe3bfkE71312xd7PJbpeT/ceK/ppJxKjsDG5mdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pXfrmYmua0twZRFvuhxMt7W8MJbwh2Lre6rJEvwDuS/nfUsF2WPCJM7kBxduidM+Y zZMMvC8paqLiNrH7tJvaB9z9xRTQqpKIyryeFcsRASAuLVYXCvAMHh5npSrXh5CD3s oaojhOJE+hcISC6kr6s5P3YJwqtHcgaWjzE05kBk= Date: Tue, 29 Dec 2020 02:07:04 +0200 From: Laurent Pinchart To: Andy Shevchenko Cc: Daniel Scally , Sakari Ailus , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Message-ID: References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> <20201228225544.GH4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Andy, On Tue, Dec 29, 2020 at 01:54:59AM +0200, Andy Shevchenko wrote: > On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote: > > > > On Tue, Dec 29, 2020 at 12:55:44AM +0200, Andy Shevchenko wrote: > > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > > > > On 28/12/2020 17:05, Sakari Ailus wrote: > > ... > > > > > Which do you prefer? > > > > > > Actually ipu3-cio2.h misses a lot of inclusions (like mutex.h which I > > > immediately noticed when scrolled over data types). > > > > Then ipu3-cio2.h should be fixed :-) > > Below is a draft patch (it is possible mangled, due to Gmail). Can you > look at it and tell me what you think? Thank you for the patch. > I believe some headers can be removed, but I have no idea about header > inclusion guarantees that v4l2 provides. > > From 10fa6c7ff66ded35a246677ffe20c677e8453f5b3 Mon Sep 17 00:00:00 2001 > From: Andy Shevchenko > Date: Tue, 29 Dec 2020 01:42:03 +0200 > Subject: [PATCH 1/1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct > user of > > Add headers that ipu3-cio2.h is direct user of. > > Signed-off-by: Andy Shevchenko > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.h | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h > b/drivers/media/pci/intel/ipu3/ipu3-cio2.h > index ccf0b85ae36f..9ea154c50ba1 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h > @@ -4,8 +4,25 @@ > #ifndef __IPU3_CIO2_H > #define __IPU3_CIO2_H > > +#include > +#include > +#include > +#include > #include > > +#include > + > +#include I think this can be dropped. > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > #define CIO2_NAME "ipu3-cio2" > #define CIO2_DEVICE_NAME "Intel IPU3 CIO2" > #define CIO2_ENTITY_NAME "ipu3-csi2" > @@ -325,6 +342,8 @@ struct csi2_bus_info { > u32 lanes; > }; > > +struct cio2_fbpt_entry; > + > struct cio2_queue { > /* mutex to be used by vb2_queue */ > struct mutex lock; > @@ -355,6 +374,8 @@ struct cio2_queue { > atomic_t bufs_queued; > }; > > +struct pci_dev; > + How about grouping all forward declarations at the top ? Otherwise this looks good, Reviewed-by: Laurent Pinchart If I was maintaining this driver I would likely move the structure definitions to ipu3-cio2.c though. > struct cio2_device { > struct pci_dev *pci_dev; > void __iomem *base; -- Regards, Laurent Pinchart