Re: [PATCH v12 03/10] drm/display: Add Type-C switch helpers

Andy Shevchenko
2023-02-22T14:09:39Z

On Wed, Feb 22, 2023 at 04:53:41PM +0800, Pin-yen Lin wrote:
> On Tue, Feb 21, 2023 at 7:48 PM Andy Shevchenko
> > On Tue, Feb 21, 2023 at 05:50:47PM +0800, Pin-yen Lin wrote:

...

> > > #include <linux/delay.h>
> > > #include <linux/i2c.h>
> > > +#include <linux/usb/typec_mux.h>
> >
> > I don't see users of this.
> > But a few forward declarations are missing.
>
> I can put a `struct typec_mux_dev;` here, but there is also a usage of
> typec_mux_set_fn_t.
>
> Should I add the typedef into this header file as well?

No, inclusion is fine, it's me who didn't notice the type in use.

--
With Best Regards,
Andy Shevchenko