From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937A8C677F1 for ; Fri, 24 Feb 2023 08:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjBXIqA (ORCPT ); Fri, 24 Feb 2023 03:46:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbjBXIp6 (ORCPT ); Fri, 24 Feb 2023 03:45:58 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 222BD63A04 for ; Fri, 24 Feb 2023 00:45:56 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id h17-20020a17090aea9100b0023739b10792so1948409pjz.1 for ; Fri, 24 Feb 2023 00:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m/g1Br9nMWuN1kMcnj12xFgT0Rd9SMTlaPziJnIgRsI=; b=HJVHq/ZFu4hLwrKBdjVcvVDh8BY2u5vhJLGEkVHDDj91kJv4YRW/orPIWQhCaQxpt3 T196f1t9afHRM06Hddxj2UDAO/ZGAp/4kLtWatrr2Okps1PTMLtqCUl5fVyPFfyBJ1r9 njk21YOnKbov8YmqfqNYhKCy42RNelscCPU+Er6jPjma9ntQP2o8VWzzyB1lhdt34cre wX8Am/J5HGndXiNov/b4ZFzZeWYXynWWExyK8oc+79LtF5/IxHIvGTbOynOGQzioxjCs 0Sh3H6i9pQCMtts9OvyTkbzRTMlymONFJDCHlrq9Da5sNVqQf+ayqR2CP41xXwzYfjyl 81bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m/g1Br9nMWuN1kMcnj12xFgT0Rd9SMTlaPziJnIgRsI=; b=Qi4jkKu+8tTLsjBpTWVwxwSrFidkflq4epYqSFFZBForJUFPqyWYKEw28fLrbP7f9J 2lQDSQ8r6SHhFpIv/qVd1W2kk1w5+QeYgpYb0QulE4aYNgOW4I6NFeZ9PA9gYlYxWuw2 NK6wb+4MTIl04ZDIQM4rsrweXv+DmltKEql9Tq1pk0LZqAjxMF3wmhDuE1L3dWE/v8Mj dLk5RkbNtxQV7mwkQ36XhM7NaTQRQ22FegTv1TmS5fUI4mhW2k57e2d6ou5F+eyy0tFq aqXwi1QWbhaNIvn1Eb0cIA+NYXD0rqdBjIgjegwMcULTo/j7qq6gi6xRucn6eYOmOJWs UYbQ== X-Gm-Message-State: AO0yUKXof9G7cmcAsG2R9V1yg3mQXUJYBugy7fluc5lL9MqsA/QNwXEq 1AB7gydkWAHhOrcZHq5RAKKSoQ== X-Google-Smtp-Source: AK7set8MdWRkAMrfAw1y8GkgFBrDn6UZ97qOIFghP/NVv/y5GdQIrkhZih6PNeZKPMELP0frUqPa5A== X-Received: by 2002:a05:6a20:3ca0:b0:be:e0c3:5012 with SMTP id b32-20020a056a203ca000b000bee0c35012mr14992895pzj.1.1677228355548; Fri, 24 Feb 2023 00:45:55 -0800 (PST) Received: from sunil-laptop ([49.206.14.226]) by smtp.gmail.com with ESMTPSA id h5-20020a62b405000000b005ae8e94b0d5sm2665775pfn.107.2023.02.24.00.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 00:45:55 -0800 (PST) Date: Fri, 24 Feb 2023 14:15:46 +0530 From: Sunil V L To: Andrew Jones Cc: Palmer Dabbelt , Albert Ou , Paul Walmsley , "Rafael J . Wysocki" , Len Brown , Thomas Gleixner , Marc Zyngier , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley , Anup Patel , Atish Patra , "Rafael J . Wysocki" Subject: Re: [PATCH V2 05/21] ACPI: Kconfig: Enable ACPI_PROCESSOR for RISC-V Message-ID: References: <20230216182043.1946553-1-sunilvl@ventanamicro.com> <20230216182043.1946553-6-sunilvl@ventanamicro.com> <20230220160518.zuppmgvvhvipawxe@orel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230220160518.zuppmgvvhvipawxe@orel> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Feb 20, 2023 at 05:05:18PM +0100, Andrew Jones wrote: > On Thu, Feb 16, 2023 at 11:50:27PM +0530, Sunil V L wrote: > > Enable the ACPI processor driver for RISC-V. > > > > Signed-off-by: Sunil V L > > Acked-by: Rafael J. Wysocki > > --- > > drivers/acpi/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > > index ccbeab9500ec..b44ac8e55b54 100644 > > --- a/drivers/acpi/Kconfig > > +++ b/drivers/acpi/Kconfig > > @@ -281,7 +281,7 @@ config ACPI_CPPC_LIB > > > > config ACPI_PROCESSOR > > tristate "Processor" > > - depends on X86 || IA64 || ARM64 || LOONGARCH > > + depends on X86 || IA64 || ARM64 || LOONGARCH || RISCV > > select ACPI_PROCESSOR_IDLE > > select ACPI_CPU_FREQ_PSS if X86 || IA64 || LOONGARCH > > select THERMAL > > -- > > 2.34.1 > > > > The commit message doesn't tell me if this is a premature config > enablement or if it's already necessary for this series. I think > if it's already necessary, then it should point out what requires > it in the commit message or be squashed into whatever patch > requires it (and also point out in that commit message why it's > required). > Thanks Drew. Let me drop this patch. We will need it in future when we need to enable LPI/CPPC etc. Thanks, Sunil