From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56577C636D4 for ; Fri, 17 Feb 2023 11:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbjBQLBx (ORCPT ); Fri, 17 Feb 2023 06:01:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjBQLBp (ORCPT ); Fri, 17 Feb 2023 06:01:45 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0D145E58C; Fri, 17 Feb 2023 03:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676631704; x=1708167704; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IK0jg8/ege2d89PKUbnoI/GAsL+o8k7CQysLNqinG18=; b=hhSkQJvOMgDU81KH+rx7LGZck6hfboMJqU4gsiRaYE0YJwfB3ASbtYyf iUe78iliRam6fqbI5xqz7FliNJkcig1YeuR+XaiPgcsTCzZLRvwZTg8aU J9146+Pe96EXO3fwPBy+hkaL1t3UKNtDYgFjic2rlOllXX06gYxxN1pW9 wdnuYRrtAv0nKn+t43A1RuNGMvxQ5jmpSB7+AjLVBzVUmJwVajW6WwTO+ 6a6g2p6rOmZsv/OM0HgVPi0kyFdyeIqca0zA2JOKQvupg4+NNdOhur1RD kqefJ61v9SADoBcpEOi53Mto+IF+7GT09JeESV4zr8siMrDyg/ZijNUdD A==; X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="320068679" X-IronPort-AV: E=Sophos;i="5.97,304,1669104000"; d="scan'208";a="320068679" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2023 03:01:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="648040359" X-IronPort-AV: E=Sophos;i="5.97,304,1669104000"; d="scan'208";a="648040359" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 17 Feb 2023 03:01:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pSyUm-008AiW-07; Fri, 17 Feb 2023 13:01:40 +0200 Date: Fri, 17 Feb 2023 13:01:39 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Scally , Heikki Krogerus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Daniel Kaehn Subject: Re: [PATCH v1 1/1] device property: Clarify description on returned value in some functions Message-ID: References: <20230216205708.13453-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Feb 17, 2023 at 12:27:53PM +0200, Sakari Ailus wrote: > On Thu, Feb 16, 2023 at 10:57:08PM +0200, Andy Shevchenko wrote: ... > > * fwnode_get_next_child_node - Return the next child node handle for a node > > * @fwnode: Firmware node to find the next child node for. > > * @child: Handle to one of the node's child nodes or a %NULL handle. > > + * > > + * Caller is responsible to call fwnode_handle_put() on the returned fwnode > > + * pointer. > > The loop itself will also put the child node, so this is only relevant > outside the loop. Yes and this is exactly what people stumbled over. Hence this note. This call per se doesn't loop, so I didn't get how your comment can be transformed to anything here. Care to elaborate a bit more on what I have to add here or reword? ... > > + * Among other cases this has to be used when terminating device_for_each_child_node() > > I don't think device_for_each_child_node() should be mentioned here. This > isn't really related to that in particular. Okay, I will drop this change. It's anyway out of the scope of this patch. > With these: > > Acked-by: Sakari Ailus Thanks, but due to above I can't apply it right away. -- With Best Regards, Andy Shevchenko