Re: [PATCH 00/24] Add basic ACPI support for RISC-V

Sunil V L
2023-02-13T04:52:01Z

Hi Conor,

On Wed, Feb 08, 2023 at 06:50:39PM +0000, Conor Dooley wrote:
> On Wed, Feb 08, 2023 at 06:28:15PM +0000, Conor Dooley wrote:
> > Hey Sunil,
> >
> > On Mon, Jan 30, 2023 at 11:52:01PM +0530, Sunil V L wrote:
> > > This patch series enables the basic ACPI infrastructure for RISC-V.
> > > Supporting external interrupt controllers is in progress and hence it is
> > > tested using polling based HVC SBI console and RAM disk.
> > >
> > > The series depends on Anup's IPI improvement series.
> > > https://github.com/avpatel/linux/commits/riscv_ipi_imp_v17
> >
> > In the future, please provide links to patchsets rather than "random"
> > git trees.
> >
> > > Jisheng Zhang (1):
> > > riscv: move sbi_init() earlier before jump_label_init()
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > What has this patch got to do with your series? Just something that was
> > sitting in your tree?
> >
> > If you need this, it'd be ideal if you would submit *with* the R-b tags
> > it appears to have had by v6 [1] & add the reason that you need to move
> > it to the commit message.
> > In Jisheng's series that was obvious, but this is a significantly larger
> > series and it is hard to spot your reasoning for it.
>
> Apologies, I forgot to provide the link!
> https://lore.kernel.org/all/20220821140918.3613-1-jszhang@kernel.org/
>

First of all, thank you very much for your detailed review!!. Will address
your comments in the next revision of the series I am preparing to send this
week.

This patch from Jisheng is required to enable ACPI for the same reason.
sbi_init() should be called before jump_label_init(). Otherwise, I hit a
panic like below.

[ 0.000000] efi: seeding entropy pool
[ 0.000000] sbi_remote_fence_i: Enter for cpu_mask = 0000000000000000
[ 0.000000] Kernel panic - not syncing: __sbi_rfence is called before sbi_init!!!
[ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.19.0-rc3-00079-gd3ee951eeea1-dirty #3
[ 0.000000] Call Trace:
[ 0.000000] [<ffffffff80005900>] dump_backtrace+0x1c/0x24
[ 0.000000] [<ffffffff8072a83e>] show_stack+0x2c/0x38
[ 0.000000] [<ffffffff8072fe7c>] dump_stack_lvl+0x40/0x58
[ 0.000000] [<ffffffff8072fea8>] dump_stack+0x14/0x1c
[ 0.000000] [<ffffffff8072ae4a>] panic+0x106/0x2c6
[ 0.000000] [<ffffffff8072a964>] sbi_remote_fence_i+0x32/0x4a
[ 0.000000] [<ffffffff80009c22>] flush_icache_all+0x1a/0x44
[ 0.000000] [<ffffffff8000622a>] patch_text_nosync+0x1e/0x2a
[ 0.000000] [<ffffffff800084da>] arch_jump_label_transform+0x48/0xd0
[ 0.000000] [<ffffffff801013ee>] __jump_label_update+0x82/0xd4
[ 0.000000] [<ffffffff801014bc>] jump_label_update+0x7c/0xca
[ 0.000000] [<ffffffff80101b5c>] static_key_enable_cpuslocked+0x70/0x9c
[ 0.000000] [<ffffffff80101b9e>] static_key_enable+0x16/0x24
[ 0.000000] [<ffffffff80730c16>] crng_set_ready+0x18/0x20
[ 0.000000] [<ffffffff80022f06>] execute_in_process_context+0x3e/0x92
[ 0.000000] [<ffffffff80730dc8>] _credit_init_bits+0x9c/0x140
[ 0.000000] [<ffffffff80827024>] add_bootloader_randomness+0x3e/0x48
[ 0.000000] [<ffffffff8082c434>] efi_config_parse_tables+0x114/0x21c
[ 0.000000] [<ffffffff8082dd18>] efi_init+0x11e/0x22a
[ 0.000000] [<ffffffff80803256>] setup_arch+0xc8/0x5fa
[ 0.000000] [<ffffffff80800716>] start_kernel+0x88/0x74e
[ 0.000000] ---[ end Kernel panic - not syncing: __sbi_rfence is called before sbi_init!!! ]---

Yes, I missed V6 of Jishang. Will update it. I will also use public
patchset linkgs.

Thanks!
Sunil