Re: [PATCH 12/24] RISC-V: ACPI: smpboot: Create wrapper smp_setup()

Conor Dooley
2023-02-08T21:34:12Z

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

On Mon, Jan 30, 2023 at 11:52:13PM +0530, Sunil V L wrote:
> Subject: RISC-V: ACPI: smpboot: Create wrapper smp_setup()

As I pointed out the other day, this one of the patches that really
doesn't warrant an ACPI: prefix.

With that fixed:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> smp_setup() currently assumes DT based platforms. To enable ACPI,
> first make this as a wrapper function and move existing code to
> a separate DT specific function.
>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
> arch/riscv/kernel/smpboot.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
> index 00b53913d4c6..26214ddefaa4 100644
> --- a/arch/riscv/kernel/smpboot.c
> +++ b/arch/riscv/kernel/smpboot.c
> @@ -70,7 +70,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
> }
> }
>
> -void __init setup_smp(void)
> +static void __init of_parse_and_init_cpus(void)
> {
> struct device_node *dn;
> unsigned long hart;
> @@ -116,6 +116,11 @@ void __init setup_smp(void)
> }
> }
>
> +void __init setup_smp(void)
> +{
> + of_parse_and_init_cpus();
> +}
> +
> static int start_secondary_cpu(int cpu, struct task_struct *tidle)
> {
> if (cpu_ops[cpu]->cpu_start)
> --
> 2.38.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]