public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: mika.westerberg@linux.intel.com, linus.walleij@linaro.org,
	brgl@bgdev.pl, linux-gpio@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	mario.limonciello@amd.com, alexander.deucher@amd.com
Subject: Re: [PATCH v3] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx
Date: Wed, 15 Feb 2023 15:28:22 +0200	[thread overview]
Message-ID: <Y+zd9kCob1i7zq11@smile.fi.intel.com> (raw)
In-Reply-To: <Y+zdi5GTO6Mdhldn@smile.fi.intel.com>

On Wed, Feb 15, 2023 at 03:26:36PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 15, 2023 at 12:59:46PM +0100, Werner Sembach wrote:
> > Am 15.02.23 um 11:49 schrieb Andy Shevchenko:
> > > On Tue, Feb 14, 2023 at 01:58:10PM +0100, Werner Sembach wrote:
> > > > commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
> > > > changed the policy such that I2C touchpads may be able to wake up the
> > > > system by default if the system is configured as such.
> > > > 
> > > > However for some devices there is a bug, that is causing the touchpad to
> > > > instantly wake up the device again once it gets deactivated. The root cause
> > > > is still under investigation:
> > > > https://lore.kernel.org/linux-acpi/2d983050-f844-6c5e-8ae9-9f87ac68dfdd@tuxedocomputers.com/T/#mb2e738787f6b6208d17b92aa6e72d4de846d4e4d
> > > Bart, I'm fine if it goes directly via your tree, or I can send it in usual
> > > bundle of fixes after rc1 (however it seems this deserves to make v6.2).

Actually we have yet another little fix. So maybe I can create a tagged bundle.
Perhaps v4 will be the best option here.

> > Just realized i did not add cc stable:
> > 
> > It is required for 6.1 also.
> 
> We have at least the following options:
> - you can send specific request for stable after it becomes a part of upstream
> - you can send a v4 with it
> 
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > 
> > > > To workaround this problem for the time being, introduce a quirk for this
> > > > model that will prevent the wakeup capability for being set for GPIO 16.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-02-15 13:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 12:58 [PATCH v3] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx Werner Sembach
2023-02-14 12:59 ` Werner Sembach
2023-02-15 10:49 ` Andy Shevchenko
2023-02-15 11:59   ` Werner Sembach
2023-02-15 13:26     ` Andy Shevchenko
2023-02-15 13:28       ` Andy Shevchenko [this message]
2023-02-15 14:37         ` Werner Sembach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+zd9kCob1i7zq11@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=alexander.deucher@amd.com \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox