Re: [PATCH v3] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx

Andy Shevchenko
2023-02-15T10:49:59Z

On Tue, Feb 14, 2023 at 01:58:10PM +0100, Werner Sembach wrote:
> commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
> changed the policy such that I2C touchpads may be able to wake up the
> system by default if the system is configured as such.
>
> However for some devices there is a bug, that is causing the touchpad to
> instantly wake up the device again once it gets deactivated. The root cause
> is still under investigation:
> https://lore.kernel.org/linux-acpi/2d983050-f844-6c5e-8ae9-9f87ac68dfdd@tuxedocomputers.com/T/#mb2e738787f6b6208d17b92aa6e72d4de846d4e4d

Bart, I'm fine if it goes directly via your tree, or I can send it in usual
bundle of fixes after rc1 (however it seems this deserves to make v6.2).

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> To workaround this problem for the time being, introduce a quirk for this
> model that will prevent the wakeup capability for being set for GPIO 16.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/gpio/gpiolib-acpi.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index e2ab4d5253bea..82e8e43582eba 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -1612,6 +1612,18 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
> .ignore_wake = "ELAN0415:00@9",
> },
> },
> + {
> + /*
> + * Spurious wakeups from TP_ATTN# pin
> + * Found in BIOS 1.7.7
> + */
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "NH5xAx"),
> + },
> + .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
> + .ignore_wake = "SYNA1202:00@16",
> + },
> + },
> {} /* Terminating entry */
> };
>
> --
> 2.34.1
>

--
With Best Regards,
Andy Shevchenko